Added feature #71 #88
Conversation
…issues section of the repo
…ification channel to publish notification when dnd is on Removed log messages
Merge from origin master
Changed notification time to reflect saved setting for exam notifications also
Pulling from origin master
Merging from origin
|
it has been some time now, when are you going to review the pull request |
|
I'm still wondering if this feature is even required, it seems extreme/unnecessary to implement this and I don't see many people finding this useful. I think people would prefer setting their device to DND on their own. |
|
my friends suggested it when I asked them what should I add to the app, so that is my motivation and they have been asking when will it be added into the released version |
Merging with origin
|
what would i have to do to get this feature added |
|
Oops, I accidentally closed this one while cleaning up some things. I apologise, it's my fault for assigning it to you without proper checking. I'm hesitant to add this feature because I don't see it being very useful to many people (I've almost never experienced someone getting a phone call during class) plus I don't think turning on DND should be a job for this application. |
|
you could just add it, those who want could use it |
Added #71 : The feature include the option to put your phone on either vibrate or silent. It requires user giving permission to change Do Not Disturb mode. It is initially turned off.
I have added condition to switch the status to off if the user when prompted to give permission does not grant the permission so as to follow the principle of least privilege.