Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken references in project and add .gitignore file. #13

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vsarpe
Copy link

@vsarpe vsarpe commented Jul 10, 2024

  1. Fixing the build: The build doesn't work out of the box. The project had broken references to Properties\AssemblyInfo.cs and packages.config. These broken references are removed and now the build works out of the box on VS 2022.
  2. Adding .gitignore: The missing .gitignore caused all build products from VS to appear in the commit diff after a build. This change will prevent accidental commits of build products and intermediates. Note: .nupkg and .snupkg file extensions are allowed (excluded from .gitignore) because the README mentioned that they might carry a .nupkg file in addition to or instead of the DLLs in the future.

The build doesn't work out of the box. The project had broken references to `Properties\AssemblyInfo.cs` and `packages.config`.

Broken references are now removed and the solution builds successfully in VS 2022.
The missing .gitignore caused all build products from VS to appear in the diff. This file will prevent accidental commits of build products and intermediates.

Note: .nupkg and .snupkg files are allowed because I saw that the README mentioned that they might carry a .nupkg file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant