Add nickname change event for OOO #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Notes This is the main working PR for building out the nickname changer as setup by a webhook call into Valkyrie. ### To-Do -[] Setup initial flow to map nickname -[] Map userID to matched nickname
Shadowfiend
approved these changes
Nov 1, 2024
Comment on lines
+62
to
+65
| // WIP, output list of all members for matching | ||
| guild.members.cache.forEach((member) => { | ||
| robot.logger.info(`Username: ${member.user.username}`) | ||
| }) |
There was a problem hiding this comment.
Can we drop those?
Also wondering if we need to start wrapping stuff in an environment check.
| }) | ||
|
|
||
| const matchedMember = guild.members.cache.find((member) => | ||
| member.user.username.includes(username), |
There was a problem hiding this comment.
Shouldn't we be looking for a direct (case-insensitive) match here?
| return matchedMember ? matchedMember.user.id : null | ||
| } | ||
|
|
||
| async function updateServerNickname( |
There was a problem hiding this comment.
This isn't just about updating the server nickname since it does all the OOO stuff, right? Let's be very specific about what this function does in the name.
| @@ -97,5 +154,37 @@ export default async function webhookDiscord( | |||
| }, | |||
| ) | |||
| robot.logger.info("Webhook is now enabled") | |||
|
|
|||
| robot.router.post("/start-date", handleAuth, async (req, res) => { | |||
There was a problem hiding this comment.
We should look at scoping this very specifically and making it a little more REST-like. Something like:
robot.router.post(`${webhookUrl}/user/:username/out-of-office`...
robot.router.delete(`${webhookUrl}/user/:username/out-of-office`...
There was a problem hiding this comment.
(I say this not remembering what webhookUrl is. We should also probably scope the message poster webhook to /message or similar.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
This is the main working PR for building out the nickname changer as setup by a webhook call into Valkyrie. It's hardcoded to have OOO, which we can also alter to pass rather than embed.
To-Do