Skip to content

fix: prevent recharts crash during streaming by enforcing schema + ru…#366

Closed
pav2345 wants to merge 2 commits intothesysdev:mainfrom
pav2345:fix/chart-streaming-crash
Closed

fix: prevent recharts crash during streaming by enforcing schema + ru…#366
pav2345 wants to merge 2 commits intothesysdev:mainfrom
pav2345:fix/chart-streaming-crash

Conversation

@pav2345
Copy link
Copy Markdown

@pav2345 pav2345 commented Mar 20, 2026

fix: prevent recharts crash during streaming

  • enforce required schema fields (labels, series)
  • add runtime guards before buildChartData
  • handle partial streaming data safely

bro test locally and merge it

@ankit-thesys ankit-thesys self-requested a review March 20, 2026 14:53
@ankit-thesys ankit-thesys self-assigned this Mar 20, 2026
Copy link
Copy Markdown
Contributor

@ankit-thesys ankit-thesys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the second commit. The prettier plugin didn't sync with the project config, so it changed all the files.

I need to test this, need some time.

@pav2345 pav2345 closed this Mar 20, 2026
@pav2345 pav2345 deleted the fix/chart-streaming-crash branch March 20, 2026 16:00
@pav2345
Copy link
Copy Markdown
Author

pav2345 commented Mar 20, 2026

“Addressed previous feedback — removed unintended formatting changes. This PR now contains only the fix.” Thank YOU Brother

@pav2345 pav2345 restored the fix/chart-streaming-crash branch March 21, 2026 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants