allow settings to be 'required=False' & tweak HTML class #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Eli,
And isn't that a fun game! I didn't actually realise this was the 'leading' branch but as it is I'm quite happy to accept any pull requests provided they have tests for any new use cases they bring about. In this case we wouldn't need one for the style change but the use of the required keyword arg is definitely something which should be tested. Thanks for the help! Darian |
…ttings. (Per-group settings do not seem to be working for me)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Your version of django-dbsettings won my game of "guess the most current fork." Dunno if you're taking patches, but I fixed the CSS on the templates so you can actually target the page with rules and I added a feature that lets you set required=False on settings if you want to allow the admin to keep the field blank.
Best,
Eli