Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter out closed PRs when finding the signing event #517

Closed
kommendorkapten opened this issue Jan 20, 2025 · 0 comments · Fixed by #518
Closed

Filter out closed PRs when finding the signing event #517

kommendorkapten opened this issue Jan 20, 2025 · 0 comments · Fixed by #518
Assignees
@kommendorkapten

Comments

@kommendorkapten
Copy link
Member

In #469 the logic for finding the PR for the signing event was changed.
This can fail when a PR is open against the signing event, as after merge they will both share the commit id, and so multiple PRs can be returned. Make sure to filter for only open PRs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kommendorkapten kommendorkapten

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

No closed prs kommendorkapten/tuf-on-ci
1 participant
@kommendorkapten