Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No closed prs #518

Merged
merged 1 commit into from
Jan 20, 2025
Merged

No closed prs #518

merged 1 commit into from
Jan 20, 2025

Conversation

kommendorkapten
Copy link
Member

Fixes: #517

@kommendorkapten kommendorkapten requested a review from jku as a code owner January 20, 2025 14:47
Signed-off-by: Fredrik Skogman <[email protected]>
Copy link
Member

@jku jku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't think of other cases that this would miss... but I'm also not 100% sure they don't exist

Anyway lgtm. Have you tested this?

@kommendorkapten
Copy link
Member Author

@kommendorkapten
Copy link
Member Author

Test to simulate root signing where a fork is used: https://github.com/jku/tuf-demo/actions/runs/12871545777/job/35885055972#step:2:450 (worked as it should)

@jku jku merged commit ca94387 into theupdateframework:main Jan 20, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter out closed PRs when finding the signing event
2 participants