chore(std): remove dead undeclared bench-stub files - #19
Merged
Conversation
Contributor
|
@ekryski confirmed both files are genuinely dead (undeclared in |
Two files in mlx/ are not declared in mlx/mod.rs (so never compiled) and use the removed metaltile-bench API (GpuRunner / OpResult): - mlx/conv.rs — a 27-line bench_conv stub returning vec![]; the real conv kernels live in kernels/convolution/. - mlx/shared.rs — a 969-line helper module whose live equivalents (dtype_label / mlx_tname / dtype_tol / EquivResult / *_typed) already exist in crate::utils; this was the orphaned original. cargo build --workspace stays green (nothing referenced either). (convolution/mlx_conv_stub.rs is the same category but is relocated by the convolution PR (#15); it'll be pruned there to avoid a move-vs-delete clash.)
TheTom
force-pushed
the
ek/prune-dead-bench-stubs
branch
from
June 22, 2026 21:24
308f6ef to
ee078dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes two dead files in
crates/metaltile-std/src/mlx/that are not declared inmlx/mod.rs(never compiled) and reference the removed metaltile-bench API (GpuRunner/OpResult):mlx/conv.rs— 27-linebench_convstub returningvec![]; real conv kernels live inkernels/convolution/.mlx/shared.rs— 969-line helper module whose live equivalents (dtype_label,mlx_tname,dtype_tol,EquivResult,*_typed) already exist incrate::utils; this was the orphaned original.cargo build --workspacestays green — nothing referenced either file. Independent of the kernel-reorg stack (offdev, touches no migrated files).convolution/mlx_conv_stub.rsis the same category but is relocated by the convolution PR (#15), so it'll be pruned there instead (deleting it here would clash with that move).