refactor: retire mlx/ — steel attention → sdpa, drop stale steel/conv dupes - #28
Conversation
b3f6f2c to
c521ca7
Compare
aa6c037 to
ff5e83d
Compare
c521ca7 to
0be5a16
Compare
ff5e83d to
722bfa8
Compare
|
@ekryski clean, steel→sdpa is a pure relocation (99-100% rename similarity, kernels unchanged), dropped steel/conv are dead dupes, registry-consistency test retargeted to Cross-cutting CI follow-up (caused by this PR + #27 removing the dirs, not a defect in the move itself): the bench-regression gate goes no-op post-merge, |
0be5a16 to
e043987
Compare
…rop dead steel/conv dupes Completes the kernel reorg: moves the steel attention templates from src/mlx/steel/attn/ to kernels/sdpa/steel_attn/ (verbatim), deletes the dead src/mlx/steel/conv duplicates and the now-empty mlx module, drops pub mod mlx from lib.rs, and repoints the kernel-registry + sdpa prefill tests at kernels/. cargo check -p metaltile-std green.
ffad7fc to
6a2035a
Compare
Carves the HIP/Vulkan device-backend changes + codegen/hip + hip/vulkan corpus tests out of #13, rebased onto the kernels/ reorg (#28). Runtime + codegen/hip are untouched by the reorg so they apply clean. vulkan_coopmat_gemm and vulkan_sdpa_multi had no net logic in #13 beyond renames the reorg already made, so they stay at the #28 version. HIP/Vulkan build validated in CI (no nvcc/vulkan on the dev mac). Follow-up to the kernel reorg.
The last legacy folder. Retires
mlx/entirely —lib.rsis now justkernels/+probe/+utils/.What moved
kernels/sdpa/steel_attn/(new) — the 4 Steel attention templates (steel_attention{,_mma,_mma_bf16,_nax}=mt_sdpa_prefill{,_mma,_mma_bf16,_nax}), alreadymt_-prefixed. Intra-refs + the 2 consumer tests repointedmlx::steel::attn→kernels::sdpa::steel_attn.What was dropped
mlx/steel/conv/(steel_conv / _3d / _general) were byte-identical stale duplicates of the already-migratedkernels/convolution/steel_conv/(doc-only "NOT YET IMPLEMENTED" placeholders — the implicit-GEMM conv needs simdgroup-matmul + im2col DSL primitives that don't exist yet). Deleted.mlx/module + itsmod.rs/steel/mod.rs.Verification
clippy --all-targets -D warningsclean; fulltile test= 1394 suites / 4125 tests / 0 failed; steel_attn external suites (sdpa_prefill_mma_long_t,_bf16_gpu) pass.With this,
mlx/andffai/are both fully retired — the entire kernel corpus lives underkernels/<family>/. Stacked on #27.