Metric improvements after integration with deployex

CHANGELOG.md

@@ -9,7 +9,9 @@
  * None
 
 ### Enhancements
- * [[`PR-13`](https://github.com/thiagoesteves/deployex/pull/13)] Fixed dialyzer configuration
+ * [[`PR-13`](https://github.com/thiagoesteves/observer_web/pull/13)] Fixed dialyzer configuration
+ * [[`PR-14`](https://github.com/thiagoesteves/observer_web/pull/14)] Improvements from code review
+ and integration
 
 # 🚀 Previous Releases
  * [0.1.7 (2025-03-21)](https://github.com/thiagoesteves/observer_web/blob/v0.1.7/CHANGELOG.md)

lib/observer_web/telemetry/storage.ex

@@ -8,7 +8,7 @@ defmodule ObserverWeb.Telemetry.Storage do
 
   @behaviour ObserverWeb.Telemetry.Adapter
 
-  @storage_table :storage_table
+  @storage_table :observer_web_metrics_table
   @mode_key "mode"
   @metric_keys "metric-keys"
   @registry_key "registry-nodes"
@@ -74,15 +74,15 @@ defmodule ObserverWeb.Telemetry.Storage do
          }}
 
       :observer ->
+        # Subscribe to receive notifications if any node is UP or Down
+        :net_kernel.monitor_nodes(true)
+
         # List all nodes including self()
         nodes = [node_self] ++ Node.list()
 
         # Subscribe to receive metrics data via PubSub
         Phoenix.PubSub.subscribe(ObserverWeb.PubSub, broadcast_topic())
 
-        # Subscribe to receive notifications if any node is UP or Down
-        :net_kernel.monitor_nodes(true)
-
         {:ok,
          %{
            nodes: nodes,
@@ -234,6 +234,9 @@ defmodule ObserverWeb.Telemetry.Storage do
 
       mode when mode in [:local, :observer] ->
         GenServer.cast(__MODULE__, msg)
+
+      _mode_not_defined_yet ->
+        :ok
     end
   end
 

lib/observer_web/tracer.ex

@@ -1,9 +1,6 @@
 defmodule ObserverWeb.Tracer do
   @moduledoc """
   This module provides Tracer context
-
-  ## References:
-   * https://github.com/thiagoesteves/deployex/blob/main/lib/deployex/tracer.ex
   """
 
   alias ObserverWeb.Rpc

lib/web/live/index.ex

@@ -3,7 +3,6 @@ defmodule Observer.Web.IndexLive do
   This module provides Observer context
 
   ## References:
-   * https://github.com/thiagoesteves/deployex/blob/main/lib/deployex_web/live/tracing/index.ex
    * https://github.com/oban-bg/oban_web/blob/main/lib/oban/web/dashboard_live.ex
   """
 

test/observer_web/telemetry/broadcast_storage_test.exs

@@ -1,4 +1,4 @@
-defmodule ObserverWeb.BroadcastStorageTest do
+defmodule ObserverWeb.Telemetry.BroadcastStorageTest do
   use ExUnit.Case, async: false
 
   alias ObserverWeb.Telemetry.Storage

test/observer_web/telemetry/local_storage_test.exs

@@ -1,4 +1,4 @@
-defmodule ObserverWeb.LocalStorageTest do
+defmodule ObserverWeb.Telemetry.LocalStorageTest do
   use ExUnit.Case, async: false
 
   import Mock

test/observer_web/telemetry/observer_storage_test.exs

@@ -1,4 +1,4 @@
-defmodule ObserverWeb.ObserverStorageTest do
+defmodule ObserverWeb.Telemetry.ObserverStorageTest do
   use ExUnit.Case, async: false
 
   import Mock

test/observer_web/telemetry/storage_test.exs

@@ -0,0 +1,9 @@
+defmodule ObserverWeb.Telemetry.StorageTest do
+  use ExUnit.Case, async: false
+
+  alias ObserverWeb.Telemetry.Storage
+
+  test "push_data/1 try to push data when mode is not configured" do
+    assert :ok == Storage.push_data(%ObserverWeb.Telemetry.Data{})
+  end
+end