Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][ADD] edi_purchase_edifact_oca #19

Open
wants to merge 3 commits into
base: 12.0
Choose a base branch
from
Open

[12.0][ADD] edi_purchase_edifact_oca #19

wants to merge 3 commits into from

Conversation

thienvh332
Copy link
Owner

No description provided.

@thienvh332 thienvh332 changed the title 12.0 add edi purchase edifact oca [12.0][ADD] edi_purchase_edifact_oca: Add new module May 3, 2024
@thienvh332 thienvh332 force-pushed the 12.0-add-edi_purchase_edifact_oca branch from 2afe8e7 to dde7b4c Compare May 3, 2024 09:14
nilshamerlinck
nilshamerlinck suggested changes May 7, 2024
View reviewed changes
edi_purchase_edifact_oca/readme/DESCRIPTION.rst Outdated Show resolved Hide resolved
edi_purchase_edifact_oca/models/purchase.py Outdated Show resolved Hide resolved
edi_purchase_edifact_oca/tests/__init__.py Outdated Show resolved Hide resolved
@nilshamerlinck
Copy link

missing:

  • in data/edi_exchange_type.xml: new output edi.exchange.type for purchase order
  • new boolean on res.partner: edi_purchase_edifact
  • listeners to implement edi_purchase_oca event on_button_confirm_purchase_order: On Purchase Order confirmation, Create EDI exchange record if partner_id.edi_purchase_edifact
  • nitpick: commit message can be simplified: [ADD] edi_purchase_edifact_oca

@thienvh332 thienvh332 force-pushed the 12.0-add-edi_purchase_edifact_oca branch 2 times, most recently from 2603443 to 8701fac Compare June 6, 2024 10:36
nilshamerlinck
nilshamerlinck suggested changes Jun 7, 2024
View reviewed changes
edi_purchase_edifact_oca/components/listener_edifact_output.py Outdated Show resolved Hide resolved
edi_purchase_edifact_oca/data/edi_backend.xml Outdated Show resolved Hide resolved
edi_purchase_edifact_oca/data/edi_backend.xml Outdated Show resolved Hide resolved
edi_purchase_edifact_oca/components/listener_edifact_output.py Outdated Show resolved Hide resolved
edi_purchase_edifact_oca/__init__.py Outdated Show resolved Hide resolved
edi_purchase_edifact_oca/data/edi_exchange_type.xml Outdated Show resolved Hide resolved
edi_purchase_edifact_oca/data/edi_exchange_type.xml Outdated Show resolved Hide resolved
@thienvh332 thienvh332 force-pushed the 12.0-add-edi_purchase_edifact_oca branch 3 times, most recently from aae1104 to 7e1afa9 Compare June 12, 2024 08:55
@thienvh332 thienvh332 force-pushed the 12.0-add-edi_purchase_edifact_oca branch 5 times, most recently from 7744538 to 632bd21 Compare August 16, 2024 04:19
@thienvh332 thienvh332 changed the title [12.0][ADD] edi_purchase_edifact_oca: Add new module [12.0][ADD] edi_purchase_edifact_oca Aug 16, 2024
@thienvh332 thienvh332 force-pushed the 12.0-add-edi_purchase_edifact_oca branch 6 times, most recently from be588d3 to 52e9eaf Compare August 20, 2024 11:13
@nilshamerlinck
Copy link

nilshamerlinck commented Aug 21, 2024 •
edited
Loading

Mutually defined

what does it mean?

@thienvh332
Copy link
Owner Author

Mutually defined

This means that the two sides regulate themselves.

Note: FTX is a very broad tag. So it depends on what data the user wants to use it to send (For example: payment term, payment method,....). So I temporarily left it as Mutually defined here.

@thienvh332 thienvh332 force-pushed the 12.0-add-edi_purchase_edifact_oca branch 6 times, most recently from 74d4222 to e554be9 Compare August 22, 2024 11:36
@thienvh332 thienvh332 force-pushed the 12.0-add-edi_purchase_edifact_oca branch 8 times, most recently from 5104210 to 88cf1fe Compare August 23, 2024 10:25
@thienvh332 thienvh332 force-pushed the 12.0-add-edi_purchase_edifact_oca branch 4 times, most recently from 1c6bcab to d3ade23 Compare September 12, 2024 10:38
@thienvh332 thienvh332 force-pushed the 12.0-add-edi_purchase_edifact_oca branch 6 times, most recently from e3c82b9 to 7b0dd00 Compare September 25, 2024 03:09
@thienvh332 thienvh332 force-pushed the 12.0-add-edi_purchase_edifact_oca branch from 7b0dd00 to 4b60ce3 Compare September 30, 2024 03:22
@thienvh332 thienvh332 force-pushed the 12.0-add-edi_purchase_edifact_oca branch from 4b60ce3 to d601b70 Compare October 1, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilshamerlinck nilshamerlinck nilshamerlinck requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thienvh332 @nilshamerlinck