Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][BPRT] edi_sale_ubl_oca #24

Open
wants to merge 32 commits into
base: 14.0
Choose a base branch
from
Open

[14.0][BPRT] edi_sale_ubl_oca #24

wants to merge 32 commits into from

Conversation

thienvh332
Copy link
Owner

No description provided.

simahawk and others added 30 commits July 1, 2024 11:08
@simahawk @thienvh332
Add edi_sale_ubl_oca
ba81455
@simahawk @thienvh332
edi_sale_ubl: improve order response data
bf4197b
@simahawk @thienvh332
edi_sale_ubl_oca: make exc type demo FIXME
6c3e09a
@simahawk @thienvh332
edi_sale_ubl_oca: depend on party data
0d21cd6
@simahawk @thienvh332
edi_sale_ubl_oca: move data to demo
78121e2
@simahawk @thienvh332
edi_sale_ubl_oca: imp OrderResponse data
6eed7fc
@simahawk @thienvh332
edi_sale_ubl_oca: fix tests
da7ee56
@simahawk @thienvh332
edi_sale_ubl: ease data override via info
1546bd2
@simahawk @thienvh332
edi_sale_ubl: fix demo data
33b68a3
@simahawk @thienvh332
edi_sale_ubl: introduce states
571c878
@simahawk @thienvh332
edi_sale_ubl: improve tests common
5008bc6
@simahawk @thienvh332
edi_sale: add edi_exchange_ready
ffe3649
@simahawk @thienvh332
edi_sale_ubl: fix state mapping
292254f
@simahawk @thienvh332
edi_sale_ubl: fix order state handling
62862e3
@simahawk @thienvh332
edi_sale_ubl: do not use Form for tests
efb50c3 
The Form class is just too dumb.
If a field is not there it's broken
and if you pass a view for a main record
you cannot pass any for the x2m fields
which makes it impossible to use for general purpose.
@simahawk @thienvh332
edi_sale_ubl: fix state update
e87a016
@simahawk @thienvh332
edi_sale_ubl: improve line state test
b9ba956
@simahawk @thienvh332
edi_sale_ubl: trigger state update on line create/write
0cccaa0
@simahawk @thienvh332
edi_sale_ubl: fix line state compute
f7df6df 
Additionally, avoid recomputing states for all lines
when we know which lines have changed.
@simahawk @thienvh332
edi_sale_ubl: fix order state compute
ffb1cae 
Several lines' state make the order not satisfied.
@simahawk @thienvh332
edi_sale_ubl: adapt to type rule
651e839
@simahawk @thienvh332
edi_sale_ubl: make state readonly
16eefc3
@simahawk @thienvh332
edi_sale_ubl: fix line state compute
b437748
@simahawk @thienvh332
edi_sale_ubl: fix tests order setup
616352c
@simahawk @thienvh332
edi_sale_ubl: fix line state compute on order create
5d7ef95
@simahawk @thienvh332
edi_sale_ubl: fix ordrsp tmpl
0dfc2ba
@simahawk @thienvh332
edi_sale_ubl: fix line state for qty=0
b38f5ec
@simahawk @thienvh332
edi_sale_ubl: fix tests, handle increased qty
c15586b
@simahawk @thienvh332
edi_sale: move OrderMixin from edi_sale_ubl
ba2ee03
@thienvh332
[IMP] edi_sale_ubl_oca: add more decorator on create method
6f9e402
@thienvh332 thienvh332 force-pushed the 14.0-bprt-edi_sale_ubl_oca branch 3 times, most recently from 146a63b to 7747214 Compare July 4, 2024 03:59
@thienvh332 thienvh332 marked this pull request as ready for review July 23, 2024 04:11
QuocDuong1306
QuocDuong1306 reviewed Jul 25, 2024
View reviewed changes
Copy link

@QuocDuong1306 QuocDuong1306 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi a @thienvh332 , I have put some reviews, could you double-check again?

edi_sale_ubl_oca/tests/test_order_in.py Outdated Show resolved Hide resolved
edi_sale_ubl_oca/tests/test_order_in_full_flow.py Outdated Show resolved Hide resolved
edi_sale_ubl_oca/tests/test_order_response_out.py Show resolved Hide resolved
edi_sale_ubl_oca/tests/test_order_response_out.py Outdated Show resolved Hide resolved
edi_sale_ubl_oca/tests/test_order_in_full_flow.py Show resolved Hide resolved
@thienvh332 thienvh332 force-pushed the 14.0-bprt-edi_sale_ubl_oca branch 4 times, most recently from 9813882 to 1081bb3 Compare August 5, 2024 07:42
QuocDuong1306
QuocDuong1306 approved these changes Aug 7, 2024
View reviewed changes
Copy link

@QuocDuong1306 QuocDuong1306 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approving

Do we need to change a little bit for commit's description?

image

edi_sale_ubl_oca/demo/edi_exchange_type.xml Show resolved Hide resolved
edi_sale_ubl_oca/demo/edi_exchange_type.xml Show resolved Hide resolved
QuocDuong1306
QuocDuong1306 approved these changes Aug 9, 2024
View reviewed changes
Copy link

@QuocDuong1306 QuocDuong1306 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[IMP] edi_sale_ubl_oca: depend on edi_exchange_type_auto

@thienvh332 thienvh332 force-pushed the 14.0-bprt-edi_sale_ubl_oca branch 2 times, most recently from 429ef55 to 50ed1be Compare August 9, 2024 03:51
@thienvh332 thienvh332 mentioned this pull request Aug 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuocDuong1306 QuocDuong1306 QuocDuong1306 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thienvh332 @QuocDuong1306 @simahawk