Added support for proprietary devices in BACnet connector #1878
+119
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am working on a clean way to inject proprietary devices classes without the need of defining custom |
|
Please do not merge this PR for now ... |
|
Feature done with dynamic loading of custom device extension. In folder |
|
@imbeacon any comments? |
|
@apachler, thanks for the PR. I will review it soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature makes it possible to inject proprietary device information the way BACpypes3 handels it.
To inject devices it is needed to import a custom class, atm this is only possible for advanced users since it is needed to implement a custom
AsyncBACnetConnectorclass.This PR makes sure the actual BACnet connector implementation is able to handle it.