Skip to content

Use NodeJS 18 in the build toolchain - bz 7899 #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Use NodeJS 18 in the build toolchain - bz 7899 #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dffd5ce
Update karma to version that's compatible with Node 18, and a few oth…
karlbecker Sep 12, 2023
f9e2c99
Upgrade CircleCI image to node 18 LTS
karlbecker Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ version: 2
settings: &settings
shell: /bin/bash --login
docker:
- image: thirdiron/tici:node-16-lts
- image: thirdiron/tici:node-18-lts
auth:
username: $DOCKER_USERNAME
password: $DOCKER_PASSWORD
Expand Down
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,5 @@
360-core-loader.js
summon-loader.js
oneLinkSummon.js

.vscode/settings.json
1 change: 1 addition & 0 deletions karma.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ module.exports = function(config) {
frameworks: ['jasmine'],

// list of files / patterns to load in the browser
// More info here: https://karma-runner.github.io/6.4/config/files.html
files: [
'node_modules/jquery/dist/jquery.js',
'node_modules/angular/angular.js',
Expand Down
10 changes: 5 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
"version": "1.8.3",
"description": "Primo, Summon, and 360 Core adapter to augment journal results with custom BrowZine API data.",
"engines": {
"node": "16.16.0",
"npm": "8.11.0"
"node": "18.16.0",
"npm": "9.5.1"
},
"scripts": {
"server": "http-server --cors -p 8080",
Expand Down Expand Up @@ -34,10 +34,10 @@
"jasmine-ajax": "^3.3.1",
"jasmine-core": "2.8.0",
"jquery": "^3.3.1",
"karma": "1.7.1",
"karma-jasmine": "1.1.0",
"karma": "6.4.2",
"karma-jasmine": "5.1.0",
"karma-mocha-reporter": "^2.2.4",
"karma-chrome-launcher": "2.2.0",
"karma-chrome-launcher": "3.2.0",
"ngrok": "^2.2.21",
"recursive-replace": "^1.0.1"
}
Expand Down