[SDK] Refactor: More Viem to Ox migration #5790
Open
+205
−270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
🦋 Changeset detectedLatest commit: 505a026 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gregfromstl
force-pushed
the
greg/viem-ox
branch
from
22cb834 to
59faac0
Compare
size-limit report 📦
|
gregfromstl
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5790 +/- ##
=======================================
Coverage 54.82% 54.83%
=======================================
Files 1141 1141
Lines 60877 60901 +24
Branches 5124 5121 -3
=======================================
+ Hits 33376 33393 +17
- Misses 26775 26782 +7
Partials 726 726
*This pull request uses carry forward flags. Click here to find out more.
|
| @@ -304,7 +308,7 @@ | |||
| dynamic, | |||
| encoded: dynamic | |||
| ? encodeParams(preparedParams) | |||
| : concat(preparedParams.map(({ encoded }) => encoded)), | |||
| : ox__Hex.concat(...preparedParams.map(({ encoded }) => encoded)), | |||
There was a problem hiding this comment.
weird choice from ox to not accept an array for concat
| @@ -134,6 +134,7 @@ describe.runIf(process.env.TW_SECRET_KEY).sequential( | |||
| account: smartAccount, | |||
| }); | |||
| expect(tx.transactionHash).toHaveLength(66); | |||
| await sleep(1000); | |||
There was a problem hiding this comment.
you can use 'confirmContractDeployment' here i think
joaquim-verges
approved these changes
Jan 7, 2025
gregfromstl
added
the
merge-queue
Merge activity
|
TOOL-0000
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on migrating functionality in the `thirdweb` package from `viem` to `ox`, improving consistency and possibly performance. It updates various files to utilize `ox` components, enhancing the codebase's integration with the `ox` library.
### Detailed summary
- Migrated `maxUint256` imports from `viem` to `ox/Solidity` in multiple files.
- Updated the `isErc6492Signature` function to use `ox__Hex.slice`.
- Changed `decodeAbiParameters` to `ox__AbiParameters.decode`.
- Replaced various utility functions with their `ox` equivalents across different modules.
- Enhanced the `verifyHash` function to utilize `ox__Signature`.
- Added new tests for `verifyContractWalletSignature` using `smartWallet`.
- Updated the workflow file to include new pull request types.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
gregfromstl
force-pushed
the
greg/viem-ox
branch
from
580f42e to
505a026
Compare
graphite-app
bot
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TOOL-0000
PR-Codex overview
This PR focuses on migrating the
maxUint256functionality fromviemtoox/Solidityacross multiple files, enhancing the codebase's consistency and reliance on theoxlibrary. It also updates workflows and introduces new tests for verifying smart account signatures.Detailed summary
maxUint256imports fromviemtoox/Solidityin several files.ready_for_reviewanddraftin pull request triggers.isErc6492Signatureto useox__Hex.slice.oxlibrary components.