Add onramp providers page to Pay overview #5836

ianthirdweb · 2024-12-24T15:35:30Z

Added onramp page and preferredPartner information to customization pages

PR-Codex overview

This PR focuses on adding support for specifying preferred onramp providers in various components and updating documentation accordingly.

Detailed summary

Added Onramp Providers option in the sidebar.
Introduced Preferred Provider section in payembed and connectbutton documentation.
Created a new onramp-providers page detailing supported providers and how to set a preferred provider.
Updated send-transaction documentation to include preferredProvider parameter.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

changeset-bot · 2024-12-24T15:35:34Z

⚠️ No Changeset found

Latest commit: 10d4b24

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2024-12-24T15:35:35Z

You must have Developer access to commit code to thirdweb on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes.

Learn more: https://vercel.com/docs/accounts/team-members-and-roles/access-roles#team-level-roles

graphite-app · 2024-12-24T15:35:37Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

graphite-app · 2024-12-24T15:36:27Z

apps/portal/src/app/connect/pay/onramp-providers/page.mdx

+		icon: "thirdweb",
+	},
+	title: "thirdweb Pay - Onramp Providers | thirdweb",
+	description: ".",


The metadata description field contains only a period. Consider adding a descriptive summary of the onramp providers page that explains its purpose and content, which will improve SEO and provide better context in search results and link previews.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

codecov · 2024-12-24T15:36:52Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.18%. Comparing base (a3f59e5) to head (18d0a22).
Report is 17 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5836   +/-   ##
=======================================
  Coverage   55.18%   55.18%           
=======================================
  Files        1123     1123           
  Lines       59617    59617           
  Branches     5025     5025           
=======================================
  Hits        32900    32900           
  Misses      25997    25997           
  Partials      720      720

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from 17d5174
packages	`52.84% <ø> (ø)`

*This pull request uses carry forward flags. Click here to find out more.

graphite-app · 2024-12-24T15:39:35Z

apps/portal/src/app/connect/pay/onramp-providers/page.mdx

+
+## Choosing a Preferred Provider
+
+It is possible to specify a preferred onramp provider by setting the `preferredProvider` parameter in the ConnectButton, PayEmbed, or Headless Integration. Go to [customizations](../pay/customization/connectbutton#preferredProvider) for more detail, or checkout the [API Reference for preferredProvider](https://portal.thirdweb.com/references/typescript/v5/GetBuyWithFiatQuoteParams).


The relative path ../pay/customization/connectbutton#preferredProvider needs to be updated to ../customization/connectbutton#preferred-provider. The anchor portion of the URL should use kebab-case to match the auto-generated heading ID from the markdown processor.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

github-actions · 2024-12-24T15:42:21Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	45.31 KB (0%)	907 ms (0%)	3.5 s (-1.79% 🔽)	4.4 s
thirdweb (cjs)	114.8 KB (0%)	2.3 s (0%)	6.2 s (-7.75% 🔽)	8.5 s
thirdweb (minimal + tree-shaking)	5.58 KB (0%)	112 ms (0%)	177 ms (+30.29% 🔺)	288 ms
thirdweb/chains (tree-shaking)	506 B (0%)	10 ms (0%)	73 ms (+27.12% 🔺)	83 ms
thirdweb/react (minimal + tree-shaking)	19.13 KB (0%)	383 ms (0%)	1.2 s (+107.54% 🔺)	1.6 s

vercel · 2025-01-04T05:53:34Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 7, 2025 3:14am

3 Skipped Deployments

Name	Status	Updated (UTC)
thirdweb_playground	⬜️ Skipped (Inspect)	Jan 7, 2025 3:14am
thirdweb-www	⬜️ Skipped (Inspect)	Jan 7, 2025 3:14am
wallet-ui	⬜️ Skipped (Inspect)	Jan 7, 2025 3:14am

gregfromstl · 2025-01-07T02:24:00Z

Merge activity

Jan 6, 9:24 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Jan 6, 9:24 PM EST: A user added this pull request to the Graphite merge queue.
Jan 6, 9:27 PM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Unit Tests').

Added onramp page and preferredPartner information to customization pages  --- ## PR-Codex overview This PR introduces new features related to onramp providers, allowing users to specify preferred providers and updates documentation across several pages to reflect these changes. ### Detailed summary - Added `Onramp Providers` section in `sidebar.tsx`. - Introduced a `Preferred Provider` section in `payembed/page.mdx` and `connectbutton/page.mdx`. - Created a new `onramp-providers/page.mdx` with details on available providers. - Updated `send-transaction/page.mdx` to include `preferredProvider` options. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

ianthirdweb requested review from jakubkrehel and a team as code owners December 24, 2024 15:35

github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Dec 24, 2024

graphite-app bot reviewed Dec 24, 2024

View reviewed changes

gregfromstl approved these changes Jan 4, 2025

View reviewed changes

gregfromstl force-pushed the ian/pay-onramps branch from d084fdf to 18d0a22 Compare January 4, 2025 06:01

vercel bot deployed to Preview – thirdweb_playground January 4, 2025 06:03 View deployment

vercel bot deployed to Preview – wallet-ui January 4, 2025 06:04 View deployment

vercel bot deployed to Preview – thirdweb-www January 4, 2025 06:07 View deployment

vercel bot deployed to Preview – docs-v2 January 4, 2025 06:10 View deployment

gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Jan 7, 2025

gregfromstl force-pushed the ian/pay-onramps branch from 18d0a22 to 10d4b24 Compare January 7, 2025 02:24

vercel bot temporarily deployed to Preview – wallet-ui January 7, 2025 02:24 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground January 7, 2025 02:24 Inactive

vercel bot temporarily deployed to Preview – thirdweb-www January 7, 2025 02:24 Inactive

graphite-app bot removed the merge-queue Adds the pull request to Graphite's merge queue. label Jan 7, 2025

vercel bot deployed to Preview – docs-v2 January 7, 2025 03:14 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add onramp providers page to Pay overview #5836

Add onramp providers page to Pay overview #5836

ianthirdweb commented Dec 24, 2024 •

edited by pr-codex bot

Loading

changeset-bot bot commented Dec 24, 2024 •

edited

Loading

vercel bot commented Dec 24, 2024

graphite-app bot commented Dec 24, 2024

graphite-app bot Dec 24, 2024

codecov bot commented Dec 24, 2024 •

edited

Loading

graphite-app bot Dec 24, 2024

github-actions bot commented Dec 24, 2024 •

edited

Loading

vercel bot commented Jan 4, 2025 •

edited

Loading

gregfromstl commented Jan 7, 2025 •

edited by graphite-app bot

Loading


		## Choosing a Preferred Provider

		It is possible to specify a preferred onramp provider by setting the `preferredProvider` parameter in the ConnectButton, PayEmbed, or Headless Integration. Go to [customizations](../pay/customization/connectbutton#preferredProvider) for more detail, or checkout the [API Reference for preferredProvider](https://portal.thirdweb.com/references/typescript/v5/GetBuyWithFiatQuoteParams).

Add onramp providers page to Pay overview #5836

Are you sure you want to change the base?

Add onramp providers page to Pay overview #5836

Conversation

ianthirdweb commented Dec 24, 2024 • edited by pr-codex bot Loading

PR-Codex overview

Detailed summary

changeset-bot bot commented Dec 24, 2024 • edited Loading

⚠️ No Changeset found

vercel bot commented Dec 24, 2024

graphite-app bot commented Dec 24, 2024

How to use the Graphite Merge Queue

graphite-app bot Dec 24, 2024

Choose a reason for hiding this comment

codecov bot commented Dec 24, 2024 • edited Loading

Codecov Report

graphite-app bot Dec 24, 2024

Choose a reason for hiding this comment

github-actions bot commented Dec 24, 2024 • edited Loading

size-limit report 📦

vercel bot commented Jan 4, 2025 • edited Loading

gregfromstl commented Jan 7, 2025 • edited by graphite-app bot Loading

Merge activity

ianthirdweb commented Dec 24, 2024 •

edited by pr-codex bot

Loading

changeset-bot bot commented Dec 24, 2024 •

edited

Loading

codecov bot commented Dec 24, 2024 •

edited

Loading

github-actions bot commented Dec 24, 2024 •

edited

Loading

vercel bot commented Jan 4, 2025 •

edited

Loading

gregfromstl commented Jan 7, 2025 •

edited by graphite-app bot

Loading