Feat/128 demos #136
Merged
Feat/128 demos #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zelig880
requested changes
Nov 3, 2025
src/components/Demos.astro
Outdated
| <div class={styles.grid}> | ||
| { | ||
| demos.map((demo) => ( | ||
| <div class={styles.card}> |
There was a problem hiding this comment.
The card are external links (as showm by the arrow shown on hover). Please change this to a Ancor and also add a link within the object
There was a problem hiding this comment.
this will also be addressed in the Mobile PR (not sure if it's merged yet, haven't checked) but it adds in width limits and spacing to all the components.
I agree with the anchor, but i don't see links in Figma.
There was a problem hiding this comment.
I'm wrong about the PR comment (i was thinking of th CCIP overview page) but yea i will fix the spacing here
tyrelchambers
force-pushed
the
feat/128-demos
branch
from
d70f42e to
6f5fd84
Compare
Zelig880
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.Any change needs to be discussed before proceeding.
Closing issues
closes #128
...
Description
The positional styling on the main page for this component will be fixed with an overall wrapper in the mobile PR
...
Changes