WIP: Feat/86 megamenu #137
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyrelchambers
force-pushed
the
feat/86-megamenu
branch
from
fca1868 to
e368dd6
Compare
|
The Lint issue here will be fixed when the Hero PR is merged in to this PR (hero pr -> this pr -> dev-3.0) because the Hero PR supports the mobile menu which is throwing the typecheck issue here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.Any change needs to be discussed before proceeding.
Closing issues
closes #86
...
Description
Adds megamenu. But, is not mobile. How do they want to make this mobile? There is a PR (Hero) to merge that code into this ticket as it is based off megamenu and has changes that should be here. When Hero is merged into Megamenu, then Megamenu in to dev-3.0, Megamenu and Hero will be complete.
Changes