Fix Anthropic adapter to support all Instructor modes #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add conditional check for tools parameter to prevent KeyError
- Remove unsupported OpenAI parameters (response_format, stop)
- Add response parsers for :json and :md_json modes
- Add comprehensive tests for all modes
- Fix formatter configuration
The adapter was failing with KeyError when accessing params.tools
for non-tools modes. This fix ensures the adapter only processes
tools when they exist and properly handles all Instructor modes.
Fixes the issue where :json and :md_json modes would crash with:
** (KeyError) key :tools not found in: %{...}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The adapter was failing with KeyError when accessing params.tools for non-tools modes. This fix ensures the adapter only processes tools when they exist and properly handles all Instructor modes.
Fixes the issue where :json and :md_json modes would crash with: ** (KeyError) key :tools not found in: %{...}