Add mul(::SMat, ::SMat)
#1228
Draft
Add mul(::SMat, ::SMat)
#1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
I have some failures in my local code that may be due to this implementation. Please wait with a merge until I looked into that. |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1228 +/- ##
==========================================
+ Coverage 74.46% 74.52% +0.05%
==========================================
Files 346 346
Lines 110830 110839 +9
==========================================
+ Hits 82534 82599 +65
+ Misses 28296 28240 -56
☔ View full report in Codecov by Sentry. |
|
Converting to a draft until I actually need it and verified the correctness. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.