fix: make alarms and identity features optional

fixes #103

.eslintrc.yaml

@@ -12,6 +12,7 @@ env:
   jest/globals: true
 parserOptions:
   sourceType: module
+  ecmaVersion: 2020
 globals:
   process: true
 rules:

src/background/controller.js

@@ -178,7 +178,7 @@ export default class Background {
     //workaround due to the `browser.alarms.get` uncatchable exception bug
     //@see https://code.google.com/p/chromium/issues/detail?id=265800
     browser.alarms.getAll().then(alarms => {
-      const exists = alarms.some(alarm => alarm.name === alarmName);
+      const exists = (alarms ?? []).some(alarm => alarm.name === alarmName);
 
       if (!exists){
         browser.alarms.create(alarmName, { periodInMinutes: 0.5 });

src/lib/angular/chrome-service.js

@@ -3,6 +3,15 @@ import browser from 'webextension-polyfill';
 
 import Preferences from '../preferences.js';
 
+/**
+ * Indicates if the browser has a certain API available, or not
+ * Not all WebExtension APIs are available at a given time (Safari 14 does not have browser.identity for instance).
+ *
+ * @param {String} cap
+ * @returns {Boolean}
+ */
+const hasCapability = (cap) => cap in browser;
+
 /**
  * Chrome API Abstraction.
  * Especially used to enables unit/function tests without relying on Chrome API direct access.
@@ -28,7 +37,8 @@ export default angular.module('ChromeService', [])
         const port = browser.runtime.connect();
         port.postMessage({ [channel]: data });
       },
-      getRedirectURL: browser.identity.getRedirectURL.bind(browser.identity),
+      hasCapability,
+      getRedirectURL: (...args) => hasCapability('identity') && browser.identity.getRedirectURL(...args),
       getUrl: path => browser.runtime.getURL(path),
     };
   });

src/now-playing/broadcast-controller.js

@@ -15,7 +15,7 @@ export default function BroadcastController($scope, chrome, preferences, $timeou
 
   $scope.stations = stations;
   $scope.currentStation = preferences.get('playback.station', 'fip-paris');
-  $scope.lastfm_enabled = lastFm.isEnabled() && preferences.get("lastfm.scrobbling") && preferences.get("lastfm.username");
+  $scope.lastfm_enabled = lastFm.isEnabled() && chrome.hasCapability("identity") && preferences.get("lastfm.scrobbling") && preferences.get("lastfm.username");
 
   $scope.broadcasts = preferences.get('broadcasts', []);
   $scope.current_index = getPosition($scope.broadcasts, $scope.broadcasts.length - 1);

src/now-playing/index.html

@@ -91,7 +91,7 @@ <h2 class="title" ng-show="!broadcast.authors">{{broadcast.title || ('no_informa
           </optgroup>
         </select>
       </li>
-      <li>
+      <li ng-if="lastfm_enabled">
         <span class="icon-lastfm" aria-label="Last.fm Status" ng-class="{'icon-activated': lastfm_enabled, 'icon-deactivated': !lastfm_enabled}"></span>
         <a href="#settings">{{ 'change_settings' | i18n }}</a>
       </li>

src/options/options-controller.js

@@ -14,7 +14,7 @@ export default function OptionsController($scope, chrome, preferences, $timeout)
   $scope.currentStation = preferences.get('playback.station', 'fip-paris');
   $scope.quality = preferences.get('playback.quality', 'hd');
   $scope.saveStatus = 'idle';
-  $scope.lastfm_enabled = lastFm.isEnabled();
+  $scope.lastfm_enabled = lastFm.isEnabled() && chrome.hasCapability("identity");
 
   $scope.save = function(){
     const prevStation = preferences.get('playback.station', 'fip-paris');