-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic load timeout #78
Conversation
only if last try is at least 10 seconds in past
"Failed to load module " | ||
+ str(self._modules[module].get_module_name()) | ||
+ " at address " | ||
+ str(self._modules[module].get_module_address()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line too long (81 > 79 characters)
Thank you! I will try to take a look this weekend and get it in. |
Hey @brefra Thanks for doing this! I was wondering if you have looked at using the existing async_scan method. This has no timeout associated and will get you module as they are discovered. I've adapted the scan.py script in examples dir to demonstrate use. |
I've seen the async_scan method. As the async_scan method only request to load the module once it will try to retrieve the module names only once too. |
Based on log supplied at #76
PR still draft, as I'm currently still testing the code changes