Skip to content

Commit

Permalink
Merge pull request #22 from thomaseizinger/release/1.3.0
Browse files Browse the repository at this point in the history
Release version 1.3.0
  • Loading branch information
thomaseizinger authored Feb 22, 2020
2 parents 9a229f1 + 24b8843 commit ad6025d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/draft-new-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ jobs:
draft-new-release:
name: "Draft a new release"
runs-on: ubuntu-latest
if: startsWith(github.event.issue.title, 'Release version') && contains(github.event.issue.labels.*.name, 'release') # only run for issues with a specific title and label
# Only run for issues with a specific title and label. Not strictly required but makes finding the release issue again later easier.
if: startsWith(github.event.issue.title, 'Release version') && contains(github.event.issue.labels.*.name, 'release')
steps:
- uses: actions/checkout@v2

Expand Down Expand Up @@ -62,7 +63,7 @@ jobs:
# We are claiming things here based on the `publish-new-release.yml` workflow.
# You should obviously adopt it to say the truth depending on your release workflow :)
body: |
Hi ${{ github.event.issue.user.login }}!
Hi @${{ github.event.issue.user.login }}!
This PR was created in response to this release issue: #${{ github.event.issue.number }}.
I've updated the changelog and bumped the versions in the manifest files in this commit: ${{ steps.make-commit.outputs.commit }}.
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/publish-new-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@ jobs:
# Hence, we close it here "manually"
- name: Close release issue
run: |
RELEASE_ISSUE_URL=$(curl https://api.github.com/repos/${{ github.repository }}/issues?labels=release&state=open | jq -r '.[1].url')
RELEASE_ISSUE_URL=$(curl https://api.github.com/repos/${{ github.repository }}/issues\?labels=release\&state=open | jq -r '.[0].url')
curl \
-X PATCH \
Expand Down

0 comments on commit ad6025d

Please sign in to comment.