Merge pull request #812 from thomasnordquist/chore/fix-broken-test-lo…

…cators fix broken test locators
thomasnordquist · Jun 17, 2024 · 03ba430 · 03ba430
2 parents 8975e7b + 61f2389
commit 03ba430
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/spec/scenarios/copyValueToClipboard.ts b/src/spec/scenarios/copyValueToClipboard.ts
@@ -2,6 +2,6 @@ import { Page } from 'playwright'
 import { clickOn } from '../util'
 
 export async function copyValueToClipboard(browser: Page) {
-  const copyButton = await browser.locator('//span[contains(text(), "Value")]//button')
+  const copyButton = await browser.getByRole('button', { name: 'Value' }).getByRole('button').first()
   await clickOn(copyButton, 1)
 }
diff --git a/src/spec/scenarios/showNumericPlot.ts b/src/spec/scenarios/showNumericPlot.ts
@@ -45,12 +45,12 @@ export async function showNumericPlot(browser: Page) {
 async function valuePreviewGuttersShowChartIcon(name: string, browser: Page) {
   for (let retries = 0; retries < 2; retries += 1) {
     try {
-      return await browser.locator(`//*[contains(@data-test-type, "ShowChart")][contains(@data-test, "${name}")]`)
+      return await browser.locator(`//*[contains(@data-test-type, "ShowChart")][contains(@data-test, "${name}")]`).first()
     } catch {
       // ignore
     }
   }
-  return browser.locator(`//*[contains(@data-test-type, "ShowChart")][contains(@data-test, "${name}")]`)
+  return browser.locator(`//*[contains(@data-test-type, "ShowChart")][contains(@data-test, "${name}")]`).first()
 }
 
 async function chartSettings(name: string, browser: Page) {