Skip to content

Commit

Permalink
prep for release
Browse files Browse the repository at this point in the history
  • Loading branch information
thomasp85 committed Jan 5, 2024
1 parent 842ba80 commit 766ad9b
Show file tree
Hide file tree
Showing 5 changed files with 196 additions and 45 deletions.
3 changes: 3 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
y-direction, but also merge duplicated titles in the other direction (#150).
* Fix a bug that prevented faceted plots with axes on the right from being
used (#340)
* Added `free()` function to mark a plot to not be aligned with the rest. The
margin of the plot will still be aligned with the margins of the other plots
but everything inside of that will by unaligned.

# patchwork 1.1.3

Expand Down
18 changes: 17 additions & 1 deletion cran-comments.md
Original file line number Diff line number Diff line change
@@ -1 +1,17 @@
This is a patch release with a range of bug fixes
Minor release with some new functionality and changes in anticipation of next
ggplot2 release

## revdepcheck results

We checked 255 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.

* We saw 0 new problems
* We failed to check 3 packages

Issues with CRAN packages are summarised below.

### Failed to check

* grandR (NA)
* Seurat (NA)
* triptych (NA)
10 changes: 6 additions & 4 deletions revdep/README.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
# Revdeps

## Failed to check (1)
## Failed to check (3)

|package |version |error |warning |note |
|:-----------|:-------|:-----|:-------|:----|
|loon.ggplot |? | | | |
|package |version |error |warning |note |
|:--------|:-------|:-----|:-------|:----|
|grandR |? | | | |
|Seurat |? | | | |
|triptych |0.1.2 |1 | | |

8 changes: 5 additions & 3 deletions revdep/cran.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
## revdepcheck results

We checked 166 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.
We checked 255 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.

* We saw 0 new problems
* We failed to check 1 packages
* We failed to check 3 packages

Issues with CRAN packages are summarised below.

### Failed to check

* loon.ggplot (NA)
* grandR (NA)
* Seurat (NA)
* triptych (NA)
202 changes: 165 additions & 37 deletions revdep/failures.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
# loon.ggplot
# grandR

<details>

* Version: 1.3.1
* GitHub: https://github.com/great-northern-diver/loon.ggplot
* Source code: https://github.com/cran/loon.ggplot
* Date/Publication: 2022-02-07 21:50:06 UTC
* Number of recursive dependencies: 104
* Version: 0.2.2
* GitHub: https://github.com/erhard-lab/grandR
* Source code: https://github.com/cran/grandR
* Date/Publication: 2023-04-20 21:22:30 UTC
* Number of recursive dependencies: 265

Run `cloud_details(, "loon.ggplot")` for more info
Run `revdepcheck::cloud_details(, "grandR")` for more info

</details>

Expand All @@ -17,25 +17,27 @@ Run `cloud_details(, "loon.ggplot")` for more info
### Devel

```
* using log directory ‘/tmp/workdir/loon.ggplot/new/loon.ggplot.Rcheck’
* using R version 4.1.1 (2021-08-10)
* using log directory ‘/tmp/workdir/grandR/new/grandR.Rcheck’
* using R version 4.3.1 (2023-06-16)
* using platform: x86_64-pc-linux-gnu (64-bit)
* R was compiled by
gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0
GNU Fortran (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0
* running under: Ubuntu 20.04.6 LTS
* using session charset: UTF-8
* using option ‘--no-manual’
* checking for file ‘loon.ggplot/DESCRIPTION’ ... OK
* checking extension type ... Package
* this is package ‘loon.ggplot’ version ‘1.3.1’
* package encoding: UTF-8
* checking package namespace information ... OK
* checking package dependencies ... ERROR
Package required but not available: ‘loon’
Package suggested but not available for checking: ‘zenplots’
See section ‘The DESCRIPTION file’ in the ‘Writing R Extensions’
manual.
* checking for file ‘grandR/DESCRIPTION’ ... OK
...
* checking installed files from ‘inst/doc’ ... OK
* checking files in ‘vignettes’ ... OK
* checking examples ... OK
* checking for unstated dependencies in vignettes ... OK
* checking package vignettes in ‘inst/doc’ ... OK
* checking running R code from vignettes ... NONE
‘getting-started.Rmd’ using ‘UTF-8’... OK
* checking re-building of vignette outputs ... OK
* DONE
Status: 1 ERROR
Status: 2 NOTEs
Expand All @@ -45,28 +47,154 @@ Status: 1 ERROR
### CRAN

```
* using log directory ‘/tmp/workdir/loon.ggplot/old/loon.ggplot.Rcheck’
* using R version 4.1.1 (2021-08-10)
* using log directory ‘/tmp/workdir/grandR/old/grandR.Rcheck’
* using R version 4.3.1 (2023-06-16)
* using platform: x86_64-pc-linux-gnu (64-bit)
* R was compiled by
gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0
GNU Fortran (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0
* running under: Ubuntu 20.04.6 LTS
* using session charset: UTF-8
* using option ‘--no-manual’
* checking for file ‘loon.ggplot/DESCRIPTION’ ... OK
* checking extension type ... Package
* this is package ‘loon.ggplot’ version ‘1.3.1’
* package encoding: UTF-8
* checking package namespace information ... OK
* checking package dependencies ... ERROR
Package required but not available: ‘loon’
Package suggested but not available for checking: ‘zenplots’
See section ‘The DESCRIPTION file’ in the ‘Writing R Extensions’
manual.
* checking for file ‘grandR/DESCRIPTION’ ... OK
...
* checking installed files from ‘inst/doc’ ... OK
* checking files in ‘vignettes’ ... OK
* checking examples ... OK
* checking for unstated dependencies in vignettes ... OK
* checking package vignettes in ‘inst/doc’ ... OK
* checking running R code from vignettes ... NONE
‘getting-started.Rmd’ using ‘UTF-8’... OK
* checking re-building of vignette outputs ... OK
* DONE
Status: 1 ERROR
Status: 2 NOTEs
```
# Seurat

<details>

* Version: 5.0.1
* GitHub: https://github.com/satijalab/seurat
* Source code: https://github.com/cran/Seurat
* Date/Publication: 2023-11-17 23:10:06 UTC
* Number of recursive dependencies: 264

Run `revdepcheck::cloud_details(, "Seurat")` for more info

</details>

## Error before installation

### Devel

```
* using log directory ‘/tmp/workdir/Seurat/new/Seurat.Rcheck’
* using R version 4.3.1 (2023-06-16)
* using platform: x86_64-pc-linux-gnu (64-bit)
* R was compiled by
gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0
GNU Fortran (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0
* running under: Ubuntu 20.04.6 LTS
* using session charset: UTF-8
* using option ‘--no-manual’
* checking for file ‘Seurat/DESCRIPTION’ ... OK
...
* checking for GNU extensions in Makefiles ... OK
* checking for portable use of $(BLAS_LIBS) and $(LAPACK_LIBS) ... OK
* checking use of PKG_*FLAGS in Makefiles ... OK
* checking compiled code ... OK
* checking examples ... OK
* checking for unstated dependencies in ‘tests’ ... OK
* checking tests ... OK
Running ‘testthat.R’
* DONE
Status: 3 NOTEs
```
### CRAN

```
* using log directory ‘/tmp/workdir/Seurat/old/Seurat.Rcheck’
* using R version 4.3.1 (2023-06-16)
* using platform: x86_64-pc-linux-gnu (64-bit)
* R was compiled by
gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0
GNU Fortran (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0
* running under: Ubuntu 20.04.6 LTS
* using session charset: UTF-8
* using option ‘--no-manual’
* checking for file ‘Seurat/DESCRIPTION’ ... OK
...
* checking for GNU extensions in Makefiles ... OK
* checking for portable use of $(BLAS_LIBS) and $(LAPACK_LIBS) ... OK
* checking use of PKG_*FLAGS in Makefiles ... OK
* checking compiled code ... OK
* checking examples ... OK
* checking for unstated dependencies in ‘tests’ ... OK
* checking tests ... OK
Running ‘testthat.R’
* DONE
Status: 3 NOTEs
```
# triptych

<details>

* Version: 0.1.2
* GitHub: https://github.com/aijordan/triptych
* Source code: https://github.com/cran/triptych
* Date/Publication: 2023-10-03 16:30:02 UTC
* Number of recursive dependencies: 64

Run `revdepcheck::cloud_details(, "triptych")` for more info

</details>

## In both

* checking whether package ‘triptych’ can be installed ... ERROR
```
Installation failed.
See ‘/tmp/workdir/triptych/new/triptych.Rcheck/00install.out’ for details.
```
## Installation
### Devel
```
* installing *source* package ‘triptych’ ...
** package ‘triptych’ successfully unpacked and MD5 sums checked
** using staged installation
** libs
Error: C++20 standard requested but CXX20 is not defined
* removing ‘/tmp/workdir/triptych/new/triptych.Rcheck/triptych’


```
### CRAN
```
* installing *source* package ‘triptych’ ...
** package ‘triptych’ successfully unpacked and MD5 sums checked
** using staged installation
** libs
Error: C++20 standard requested but CXX20 is not defined
* removing ‘/tmp/workdir/triptych/old/triptych.Rcheck/triptych’


```

0 comments on commit 766ad9b

Please sign in to comment.