[tidy] Clean up messy code for isNewClassNecessary()

thoni56 · Sep 13, 2023 · acca77a · acca77a
1 parent 1fdef06
commit acca77a
Showing 1 changed file with 10 additions and 10 deletions.
diff --git a/src/extract.c b/src/extract.c
@@ -1223,20 +1223,20 @@ static void javaGenerateNewClassTail(ProgramGraphNode *program) {
     ppcGenRecord(PPC_STRING_VALUE, resultingString);
 }
 
+static bool isClassifiedAsAnyTypeOfOutArgument(ProgramGraphNode *p) {
+    return p->classification == CLASSIFIED_AS_OUT_ARGUMENT
+        || p->classification == CLASSIFIED_AS_LOCAL_OUT_ARGUMENT
+        || p->classification == CLASSIFIED_AS_IN_OUT_ARGUMENT;
+}
+
 /* ******************************************************************* */
 
 static bool isNewClassNecessary(ProgramGraphNode *program) {
-    ProgramGraphNode  *p;
-    for (p=program; p!=NULL; p=p->next) {
-        if (p->classification == CLASSIFIED_AS_OUT_ARGUMENT
-            || p->classification == CLASSIFIED_AS_LOCAL_OUT_ARGUMENT
-            || p->classification == CLASSIFIED_AS_IN_OUT_ARGUMENT
-        )
-            break;
+    for (ProgramGraphNode *p=program; p!=NULL; p=p->next) {
+        if (isClassifiedAsAnyTypeOfOutArgument(p))
+            return true;
     }
-    if (p==NULL)
-        return false;
-    return true;
+    return false;
 }
 
 static bool programStructureMismatch() {