Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python interface #3

Closed
wants to merge 20 commits into from
Closed

Python interface #3

wants to merge 20 commits into from

Conversation

burgerdev
Copy link

There are some differences to what the CC class used to be:

  • vigra::TinyVector is no longer exported (this is done in vigra)
  • the CC class is not exported for float anymore
  • messages to stdout were removed
  • _import_array() is no longer called during module init
  • label type is now unsigned int (int before)
  • CC class is now also templated with source type
  • Roi has new getter and setter methods for p and q (problem with TinyVector converters)
  • removed const from sink TinyVectors for compatibility (they are returned by-value anyways)

@@ -74,6 +74,7 @@ def test1():
ba.setCompressionEnabled(True)
ba.setCompressionEnabled(False)


Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty line

@thorbenk
Copy link
Owner

I would suggest to git rebase --interactive these commits and either squash all or refactor commits into at most three distinct commits

@burgerdev
Copy link
Author

I will squash them in the next pull request, but will keep committing here until its ready.

@burgerdev
Copy link
Author

squashed in #4

@burgerdev burgerdev closed this Mar 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants