Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADR for kebechet optimization #393

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

KPostOffice
Copy link
Member

Related Issues and Dependencies

thoth-station/kebechet#873

This introduces a breaking change

  • No

@sesheta sesheta added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 15, 2022
@KPostOffice
Copy link
Member Author

@thoth-station/devs

@KPostOffice KPostOffice force-pushed the keb_optimization_adr branch from 20e5417 to db57401 Compare March 15, 2022 22:24
@goern goern requested a review from fridex March 16, 2022 16:01
* Good, segregating functionality helps users understand what they are installing
* Good, workloads can be very selectively run through thorough web-hook processing
* Bad, many small deployments

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad, is is not a good user experience, if a user needs to install many GH apps
Good, freedom of choice

@sesheta
Copy link
Member

sesheta commented Jun 14, 2022

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@sesheta sesheta added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 14, 2022
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@harshad16 harshad16 merged commit f60775a into thoth-station:master Jun 17, 2022
@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2022
@sesheta
Copy link
Member

sesheta commented Jun 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants