Fix hash handling jira consumer (#90)

* fixed bug where only the jira consumer would ignore hashes * styling
thought-machine · Mar 3, 2021 · a8e9ced · a8e9ced
1 parent 40d1ed7
commit a8e9ced
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 6 deletions.
diff --git a/common/jira/document/document.go b/common/jira/document/document.go
@@ -27,7 +27,7 @@ func NewRaw(scanStartTime time.Time, res *v1.LaunchToolResponse, iss *v1.Issue)
 		FirstFound:     scanStartTime,
 		Count:          "1",
 		FalsePositive:  "false",
-        Hash:           "",
+		Hash:           "",
 		// The fields below are not used in this consumer. We use the text versions instead.
 		// Severity:       iss.GetSeverity(),
 		// Confidence:     iss.GetConfidence(),
@@ -57,7 +57,7 @@ func NewEnriched(scanStartTime time.Time, res *v1.EnrichedLaunchToolResponse, is
 		FirstFound:     firstSeenTime,
 		Count:          strconv.Itoa(int(iss.GetCount())),          // formatted as string
 		FalsePositive:  strconv.FormatBool(iss.GetFalsePositive()), // formatted as string
-        Hash:           iss.GetHash(),
+		Hash:           iss.GetHash(),
 		// The fields below are not used in this consumer. We use the text versions instead.
 		// Severity:       iss.GetRawIssue().GetSeverity(),
 		// Confidence:     iss.GetRawIssue().GetConfidence(),

diff --git a/common/jira/document/types.go b/common/jira/document/types.go
@@ -20,7 +20,7 @@ type Document struct {
 	FirstFound     time.Time `json:"first_found"`
 	Count          string    `json:"count"`
 	FalsePositive  string    `json:"false_positive"`
-    Hash           string    `json:"hash"`
+	Hash           string    `json:"hash"`
 	// The fields below are not used in this consumer. We use the text versions instead.
 	// Severity   v1.Severity   `json:"severity"`
 	// Confidence v1.Confidence `json:"confidence"`

diff --git a/common/jira/jira/api.go b/common/jira/jira/api.go
@@ -3,7 +3,9 @@ package jira
 import (
 	"io/ioutil"
 	"log"
+
 	"github.com/andygrunwald/go-jira"
+
 	"github.com/thought-machine/dracon/common/jira/config"
 )
 

diff --git a/consumers/jira_c/utils/utils.go b/consumers/jira_c/utils/utils.go
@@ -1,13 +1,14 @@
 package utils
 
 import (
-
 	"encoding/json"
 	"log"
+
 	"github.com/golang/protobuf/ptypes"
-	"github.com/thought-machine/dracon/consumers"
+
 	v1 "github.com/thought-machine/dracon/api/proto/v1"
 	"github.com/thought-machine/dracon/common/jira/document"
+	"github.com/thought-machine/dracon/consumers"
 )
 
 // ProcessMessages processess all the v1.LaunchToolResponses (or v1.EnrichedToolResponses if consumers.Raw is false) and returns:

diff --git a/consumers/jira_c/utils/utils_test.go b/consumers/jira_c/utils/utils_test.go
@@ -99,7 +99,6 @@ func TestProcessRawMessages(t *testing.T) {
                                          "count": "1",
                                          "false_positive": "false",
                                          "hash":""}
-
     response := []*v1.LaunchToolResponse{
         &v1.LaunchToolResponse{
             ToolName: "test",