Skip to content

Support linking to STI models #2859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Support linking to STI models #2859

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58e4b3d
Support STI models in #accessible_action?
matteeyah Jun 12, 2025
a50efb4
Merge branch 'thoughtbot:main' into main
matteeyah Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion app/helpers/administrate/application_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def accessible_action?(target, action_name)
target.is_a?(ActiveRecord::Base) ? target.class : target

existing_action?(target_class_or_class_name, action_name) &&
authorized_action?(target, action_name)
authorized_action?(target, action_name) || superclass_accessible_action?(target, action_name)
end

def display_resource_name(resource_name, opts = {})
Expand Down Expand Up @@ -97,5 +97,12 @@ def default_resource_name(name, opts = {})
resource_name = (opts[:singular] ? name.to_s : name.to_s.pluralize)
resource_name.tr("/", "_").titleize
end

def superclass_accessible_action?(target, action_name)
return false unless target.is_a?(ActiveRecord::Base)
return false unless target.class.superclass <= target.class.base_class

accessible_action?(target.becomes(target.class.superclass), action_name)
end
end
end