-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade all the things #22
base: master
Are you sure you want to change the base?
Conversation
mike-burns
commented
Apr 12, 2019
- Gradle
- Kotlin
- target and compilation SDK
- AndroidX
- Gradle - Kotlin - target and compilation SDK - AndroidX
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrade-orific!
@@ -24,6 +24,6 @@ fun String.colorSubString(subString: String, color: Int): SpannableStringBuilder | |||
return stringBuilder | |||
} | |||
|
|||
fun RecyclerView.attachSnapHelper(snapHelper: SnapHelper) { | |||
fun androidx.recyclerview.widget.RecyclerView.attachSnapHelper(snapHelper: androidx.recyclerview.widget.SnapHelper) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this should be fully qualified, right? It makes it very noisy.
import android.view.MotionEvent | ||
import com.thoughtbot.tropos.scrolling.OverScroller.OverScrollDirection.END | ||
|
||
class RecyclerViewScroller(override val view: RecyclerView) : Scroller { | ||
class RecyclerViewScroller(override val view: androidx.recyclerview.widget.RecyclerView) : Scroller { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto here
@@ -36,17 +36,17 @@ class RecyclerViewScroller(override val view: RecyclerView) : Scroller { | |||
|
|||
} | |||
|
|||
fun RecyclerView.setVerticalEndOverScroller() { | |||
fun androidx.recyclerview.widget.RecyclerView.setVerticalEndOverScroller() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And here but I'm going to stop commenting it now :)
@@ -19,6 +23,10 @@ buildscript { | |||
allprojects { | |||
repositories { | |||
jcenter() | |||
maven { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should be able to use the google()
method here instead of specifying the google maven repo