Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addons: Remove PackedPhongMaterial. #1256

Merged
merged 5 commits into from
Sep 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion examples-testing/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ const exceptionList = [
'webgl_postprocessing_3dlut',
'webgl_postprocessing_dof',
'webgl_postprocessing_dof2',
'webgl_buffergeometry_compression',
'webgl_rendertarget_texture2darray',
'webgl_texture2darray',
'webgl_worker_offscreencanvas',
Expand Down
1 change: 0 additions & 1 deletion types/three/examples/jsm/Addons.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,6 @@ export * as CameraUtils from "./utils/CameraUtils.js";
export * as GeometryCompressionUtils from "./utils/GeometryCompressionUtils.js";
export * as GeometryUtils from "./utils/GeometryUtils.js";
export * from "./utils/LDrawUtils.js";
export * from "./utils/PackedPhongMaterial.js";
export * as SceneUtils from "./utils/SceneUtils.js";
export * from "./utils/ShadowMapViewer.js";
export * as SkeletonUtils from "./utils/SkeletonUtils.js";
Expand Down
24 changes: 20 additions & 4 deletions types/three/examples/jsm/utils/GeometryCompressionUtils.d.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,21 @@
import { Mesh } from "three";
import { BufferGeometry, Mesh } from "three";

export function compressNormals(mesh: Mesh, encodeMethod: string): void;
export function compressPositions(mesh: Mesh): void;
export function compressUvs(mesh: Mesh): void;
/**
* Make the input geometry's normal attribute encoded and compressed by 3 different methods.
*/
declare function compressNormals(
geometry: BufferGeometry,
encodeMethod: "DEFAULT" | "OCT1Byte" | "OCT2Byte" | "ANGLES",
): void;

/**
* Make the input geometry's position attribute encoded and compressed.
*/
declare function compressPositions(geometry: BufferGeometry): void;

/**
* Make the input geometry's uv attribute encoded and compressed.
*/
declare function compressUvs(geometry: BufferGeometry): void;

export { compressNormals, compressPositions, compressUvs };
10 changes: 0 additions & 10 deletions types/three/examples/jsm/utils/PackedPhongMaterial.d.ts

This file was deleted.

Loading