Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(WebGLRenderer): physicallyCorrectLights => useLegacyLights #373

Closed
wants to merge 31 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
88431c2
chore: add test for ViewHelper
joshuaellis Jan 30, 2023
e49e750
r149
joshuaellis Jan 30, 2023
4f948d7
chore: remove Capsule from OTHER_FILES
joshuaellis Jan 30, 2023
17b4f7e
chore: remove octree from OTHER_FILES
joshuaellis Jan 30, 2023
ea243f4
Update MarchingCubes.d.ts to include missing signature for update() (…
jackbonaguro Jan 31, 2023
56ec692
add 0b5vr as a contributor for maintenance, review, and bug (#334)
allcontributors[bot] Jan 31, 2023
539d058
Upgrade to Yarn Modern (#339)
Methuselah96 Feb 6, 2023
08f669a
chore: Set Git line endings to LF for Windows users (#338)
Methuselah96 Feb 6, 2023
7c4b432
Configure Renovate (#341)
renovate[bot] Feb 6, 2023
e90a3aa
chore(deps): update actions/setup-node action to v3 (#346)
renovate[bot] Feb 6, 2023
bcf0b7a
chore(deps): update actions/checkout action to v3 (#345)
renovate[bot] Feb 6, 2023
c1931f8
chore(deps): update dependency prettier to v2.8.3 (#344)
renovate[bot] Feb 6, 2023
400332f
Add exports field to package.json (#340)
Methuselah96 Feb 6, 2023
3753c40
chore(deps): update dependency husky to v8 (#347)
renovate[bot] Feb 6, 2023
2abec4a
Fix Earcut.triangulate return value (#348)
Methuselah96 Feb 6, 2023
93c10f1
Replace constant enums with constant type unions (#349)
Methuselah96 Feb 7, 2023
3382f01
check color names (#350)
rotu Feb 13, 2023
aacd725
Remove Earcut export (#351)
Methuselah96 Feb 20, 2023
c5f86a1
Add "type": "module" (#352)
Methuselah96 Feb 20, 2023
d39ea62
Fix usage with "module": "nodenext" (#356)
Methuselah96 Feb 24, 2023
2ab523f
Cleanup deprecated code and Update documentation for BufferGeometry a…
rafaelsc Feb 28, 2023
d99a0ff
Update documentation for ThreeJS Core Classes (#354)
rafaelsc Feb 28, 2023
0507651
chore(deps): update all non-major dependencies (#360)
renovate[bot] Mar 1, 2023
39d62cf
chore(deps): update dependency prettier to v2.8.4 (#361)
renovate[bot] Mar 1, 2023
12a74d8
chore(deps): lock file maintenance (#362)
renovate[bot] Mar 1, 2023
a3c3b8e
Add types for lil-gui (#358)
Methuselah96 Mar 2, 2023
945a43d
Re-export @types/stats.js (#363)
Methuselah96 Mar 2, 2023
6127cbb
Re-export types from fflate (#364)
Methuselah96 Mar 2, 2023
387be2f
Update OctreeHelper constructor to make second parameter optional (#366)
Methuselah96 Mar 7, 2023
74692d2
Allow Color to be set from an InterleavedBufferAttribute (#359)
Methuselah96 Mar 7, 2023
9b62772
fix(WebGLRenderer): physicallyCorrectLights => useLegacyLights
CodyJasonBennett Mar 13, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion .all-contributorsrc
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,10 @@
"profile": "http://0b5vr.github.io/",
"contributions": [
"code",
"test"
"test",
"maintenance",
"review",
"bug"
]
},
{
Expand Down Expand Up @@ -665,6 +668,25 @@
"contributions": [
"code"
]
},
{
"login": "jackbonaguro",
"name": "Jack Bonaguro",
"avatar_url": "https://avatars.githubusercontent.com/u/15988128?v=4",
"profile": "https://github.com/jackbonaguro",
"contributions": [
"code"
]
},
{
"login": "rafaelsc",
"name": "Rafael Sliveira Cordeiro",
"avatar_url": "https://avatars.githubusercontent.com/u/502282?v=4",
"profile": "https://github.com/rafaelsc",
"contributions": [
"code",
"doc"
]
}
],
"skipCi": true,
Expand Down
1 change: 1 addition & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
* text=auto eol=lf
4 changes: 2 additions & 2 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '12'

Expand Down
8 changes: 8 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,11 @@ lerna-debug.log*

*.tgz
.DS_Store

.pnp.*
.yarn/*
!.yarn/patches
!.yarn/plugins
!.yarn/releases
!.yarn/sdks
!.yarn/versions
2 changes: 2 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
.pnp.*
.yarn/*
873 changes: 873 additions & 0 deletions .yarn/releases/yarn-3.4.1.cjs

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions .yarnrc.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
yarnPath: .yarn/releases/yarn-3.4.1.cjs
nodeLinker: node-modules
4 changes: 3 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/d
<td align="center" valign="top" width="14.28%"><a href="https://github.com/Methuselah96"><img src="https://avatars.githubusercontent.com/u/693755?v=4?s=100" width="100px;" alt="Nathan Bierema"/><br /><sub><b>Nathan Bierema</b></sub></a><br /><a href="#question-Methuselah96" title="Answering Questions">💬</a> <a href="https://github.com/three-types/three-ts-types/issues?q=author%3AMethuselah96" title="Bug reports">🐛</a> <a href="https://github.com/three-types/three-ts-types/commits?author=Methuselah96" title="Code">💻</a> <a href="https://github.com/three-types/three-ts-types/commits?author=Methuselah96" title="Documentation">📖</a> <a href="#ideas-Methuselah96" title="Ideas, Planning, & Feedback">🤔</a> <a href="#infra-Methuselah96" title="Infrastructure (Hosting, Build-Tools, etc)">🚇</a> <a href="#maintenance-Methuselah96" title="Maintenance">🚧</a> <a href="https://github.com/three-types/three-ts-types/pulls?q=is%3Apr+reviewed-by%3AMethuselah96" title="Reviewed Pull Requests">👀</a> <a href="https://github.com/three-types/three-ts-types/commits?author=Methuselah96" title="Tests">⚠️</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://human-interactive.org"><img src="https://avatars.githubusercontent.com/u/12612165?v=4?s=100" width="100px;" alt="Michael Herzog"/><br /><sub><b>Michael Herzog</b></sub></a><br /><a href="https://github.com/three-types/three-ts-types/commits?author=Mugen87" title="Code">💻</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/CodyJasonBennett"><img src="https://avatars.githubusercontent.com/u/23324155?v=4?s=100" width="100px;" alt="Cody Bennett"/><br /><sub><b>Cody Bennett</b></sub></a><br /><a href="https://github.com/three-types/three-ts-types/commits?author=CodyJasonBennett" title="Code">💻</a></td>
<td align="center" valign="top" width="14.28%"><a href="http://0b5vr.github.io/"><img src="https://avatars.githubusercontent.com/u/7824814?v=4?s=100" width="100px;" alt="0b5vr"/><br /><sub><b>0b5vr</b></sub></a><br /><a href="https://github.com/three-types/three-ts-types/commits?author=0b5vr" title="Code">💻</a> <a href="https://github.com/three-types/three-ts-types/commits?author=0b5vr" title="Tests">⚠️</a></td>
<td align="center" valign="top" width="14.28%"><a href="http://0b5vr.github.io/"><img src="https://avatars.githubusercontent.com/u/7824814?v=4?s=100" width="100px;" alt="0b5vr"/><br /><sub><b>0b5vr</b></sub></a><br /><a href="https://github.com/three-types/three-ts-types/commits?author=0b5vr" title="Code">💻</a> <a href="https://github.com/three-types/three-ts-types/commits?author=0b5vr" title="Tests">⚠️</a> <a href="#maintenance-0b5vr" title="Maintenance">🚧</a> <a href="https://github.com/three-types/three-ts-types/pulls?q=is%3Apr+reviewed-by%3A0b5vr" title="Reviewed Pull Requests">👀</a> <a href="https://github.com/three-types/three-ts-types/issues?q=author%3A0b5vr" title="Bug reports">🐛</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://stackoverflow.com/users/2608515/marquizzo"><img src="https://avatars.githubusercontent.com/u/7864858?v=4?s=100" width="100px;" alt="Marquizzo"/><br /><sub><b>Marquizzo</b></sub></a><br /><a href="https://github.com/three-types/three-ts-types/commits?author=marquizzo" title="Code">💻</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/khum08"><img src="https://avatars.githubusercontent.com/u/32336026?v=4?s=100" width="100px;" alt="Yuanzk"/><br /><sub><b>Yuanzk</b></sub></a><br /><a href="https://github.com/three-types/three-ts-types/commits?author=khum08" title="Code">💻</a></td>
</tr>
Expand Down Expand Up @@ -119,6 +119,8 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/d
</tr>
<tr>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/saitonakamura"><img src="https://avatars.githubusercontent.com/u/1552189?v=4?s=100" width="100px;" alt="Michael サイトー 中村 Bashurov"/><br /><sub><b>Michael サイトー 中村 Bashurov</b></sub></a><br /><a href="https://github.com/three-types/three-ts-types/commits?author=saitonakamura" title="Code">💻</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/jackbonaguro"><img src="https://avatars.githubusercontent.com/u/15988128?v=4?s=100" width="100px;" alt="Jack Bonaguro"/><br /><sub><b>Jack Bonaguro</b></sub></a><br /><a href="https://github.com/three-types/three-ts-types/commits?author=jackbonaguro" title="Code">💻</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/rafaelsc"><img src="https://avatars.githubusercontent.com/u/502282?v=4?s=100" width="100px;" alt="Rafael Sliveira Cordeiro"/><br /><sub><b>Rafael Sliveira Cordeiro</b></sub></a><br /><a href="https://github.com/three-types/three-ts-types/commits?author=rafaelsc" title="Code">💻</a> <a href="https://github.com/three-types/three-ts-types/commits?author=rafaelsc" title="Documentation">📖</a></td>
</tr>
</tbody>
</table>
Expand Down
16 changes: 9 additions & 7 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,16 @@
"@definitelytyped/dtslint-runner": "latest",
"@definitelytyped/header-parser": "latest",
"@definitelytyped/utils": "latest",
"all-contributors-cli": "^6.19.0",
"husky": "^7.0.1",
"prettier": "2.3.2",
"pretty-quick": "^3.1.1",
"@types/stats.js": "*",
"@types/webxr": "*",
"all-contributors-cli": "^6.24.0",
"fflate": "~0.6.9",
"husky": "^8.0.3",
"lil-gui": "~0.17.0",
"prettier": "2.8.4",
"pretty-quick": "^3.1.3",
"source-map-support": "^0.5.21",
"typescript": "next"
},
"dependencies": {
"@types/webxr": "^0.5.1"
}
"packageManager": "[email protected]"
}
14 changes: 14 additions & 0 deletions renovate.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"extends": ["config:base", "group:allNonMajor", "schedule:monthly", ":maintainLockFilesMonthly"],
"rangeStrategy": "bump",
"postUpdateOptions": ["yarnDedupeHighest"],
"rebaseWhen": "conflicted",
"packageRules": [
{
"matchPackageNames": ["prettier"],
"matchUpdateTypes": ["major", "minor", "patch"],
"groupName": "prettier"
}
]
}
8 changes: 3 additions & 5 deletions types/three/OTHER_FILES.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
build/three.d.cts
build/three.d.ts
build/three.module.d.ts
examples/jsm/animation/AnimationClipCreator.d.ts
examples/jsm/csm/CSMShader.d.ts
examples/jsm/curves/NURBSCurve.d.ts
Expand Down Expand Up @@ -30,7 +33,6 @@ examples/jsm/helpers/OctreeHelper.d.ts
examples/jsm/helpers/PositionalAudioHelper.d.ts
examples/jsm/helpers/VertexNormalsHelper.d.ts
examples/jsm/helpers/VertexTangentsHelper.d.ts
examples/jsm/helpers/ViewHelper.d.ts
examples/jsm/interactive/HTMLMesh.d.ts
examples/jsm/interactive/InteractiveGroup.d.ts
examples/jsm/libs/stats.module.d.ts
Expand All @@ -56,7 +58,6 @@ examples/jsm/loaders/LWOLoader.d.ts
examples/jsm/loaders/MD2Loader.d.ts
examples/jsm/loaders/MDDLoader.d.ts
examples/jsm/loaders/NRRDLoader.d.ts
examples/jsm/loaders/PCDLoader.d.ts
examples/jsm/loaders/PDBLoader.d.ts
examples/jsm/loaders/PLYLoader.d.ts
examples/jsm/loaders/PRWMLoader.d.ts
Expand All @@ -68,13 +69,11 @@ examples/jsm/loaders/TiltLoader.d.ts
examples/jsm/loaders/VRMLLoader.d.ts
examples/jsm/loaders/VTKLoader.d.ts
examples/jsm/loaders/XYZLoader.d.ts
examples/jsm/math/Capsule.d.ts
examples/jsm/math/ColorConverter.d.ts
examples/jsm/math/ConvexHull.d.ts
examples/jsm/math/Lut.d.ts
examples/jsm/math/MeshSurfaceSampler.d.ts
examples/jsm/math/OBB.d.ts
examples/jsm/math/Octree.d.ts
examples/jsm/misc/ConvexObjectBreaker.d.ts
examples/jsm/misc/Gyroscope.d.ts
examples/jsm/misc/MD2Character.d.ts
Expand Down Expand Up @@ -168,7 +167,6 @@ examples/jsm/shaders/VerticalTiltShiftShader.d.ts
examples/jsm/shaders/VignetteShader.d.ts
examples/jsm/shaders/VolumeShader.d.ts
examples/jsm/shaders/WaterRefractionShader.d.ts
examples/jsm/utils/BufferGeometryUtils.d.ts
examples/jsm/utils/GeometryCompressionUtils.d.ts
examples/jsm/utils/PackedPhongMaterial.d.ts
examples/jsm/utils/SceneUtils.d.ts
Expand Down
2 changes: 2 additions & 0 deletions types/three/build/three.d.cts
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
export * from '../src/Three';
export as namespace THREE;
2 changes: 2 additions & 0 deletions types/three/build/three.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
export * from '../src/Three';
export as namespace THREE;
2 changes: 2 additions & 0 deletions types/three/build/three.module.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
export * from '../src/Three';
export as namespace THREE;
6 changes: 3 additions & 3 deletions types/three/examples/jsm/controls/OrbitControls.d.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Camera, MOUSE, TOUCH, Vector3 } from '../../../src/Three';
import { Camera, MOUSE, MouseButton, TOUCH, TouchCount, Vector3 } from '../../../src/Three';

/**
* Orbit controls allow the camera to orbit around a target.
Expand Down Expand Up @@ -193,13 +193,13 @@ export class OrbitControls {
* This object contains references to the mouse actions used
* by the controls.
*/
mouseButtons: Partial<{ LEFT: MOUSE; MIDDLE: MOUSE; RIGHT: MOUSE }>;
mouseButtons: Partial<{ LEFT: MouseButton; MIDDLE: MouseButton; RIGHT: MouseButton }>;

/**
* This object contains references to the touch actions used by
* the controls.
*/
touches: Partial<{ ONE: TOUCH; TWO: TOUCH }>;
touches: Partial<{ ONE: TouchCount; TWO: TouchCount }>;

/**
* Used internally by the .saveState and .reset methods.
Expand Down
4 changes: 2 additions & 2 deletions types/three/examples/jsm/controls/TrackballControls.d.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Camera, EventDispatcher, MOUSE, Vector3 } from '../../../src/Three';
import { Camera, EventDispatcher, MOUSE, MouseButton, Vector3 } from '../../../src/Three';

export class TrackballControls extends EventDispatcher {
constructor(object: Camera, domElement?: HTMLElement);
Expand All @@ -21,7 +21,7 @@ export class TrackballControls extends EventDispatcher {
minDistance: number;
maxDistance: number;
keys: string[];
mouseButtons: { LEFT: MOUSE; MIDDLE: MOUSE; RIGHT: MOUSE };
mouseButtons: { LEFT: MouseButton; MIDDLE: MouseButton; RIGHT: MouseButton };

target: Vector3;
position0: Vector3;
Expand Down
8 changes: 4 additions & 4 deletions types/three/examples/jsm/controls/TransformControls.d.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Object3D, Camera, MOUSE, Raycaster, Mesh, Vector3, Quaternion } from '../../../src/Three';
import { Object3D, Camera, MOUSE, Raycaster, Mesh, Vector3, Quaternion, MouseButton } from '../../../src/Three';

export class TransformControls extends Object3D {
constructor(object: Camera, domElement?: HTMLElement);
Expand All @@ -22,9 +22,9 @@ export class TransformControls extends Object3D {
showZ: boolean;
readonly isTransformControls: true;
mouseButtons: {
LEFT: MOUSE;
MIDDLE: MOUSE;
RIGHT: MOUSE;
LEFT: MouseButton;
MIDDLE: MouseButton;
RIGHT: MouseButton;
};

attach(object: Object3D): this;
Expand Down
2 changes: 1 addition & 1 deletion types/three/examples/jsm/helpers/OctreeHelper.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { ColorRepresentation, LineSegments } from '../../../src/Three';
import { Octree } from '../math/Octree';

export class OctreeHelper extends LineSegments {
constructor(octree: Octree, color: ColorRepresentation);
constructor(octree: Octree, color?: ColorRepresentation);

octree: Octree;
color: ColorRepresentation;
Expand Down
1 change: 1 addition & 0 deletions types/three/examples/jsm/libs/fflate.module.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export * from 'fflate';
Loading