Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Add stopListenToKeyEvents to OrbitControls #376

Merged
merged 1 commit into from
Mar 20, 2023
Merged

feature: Add stopListenToKeyEvents to OrbitControls #376

merged 1 commit into from
Mar 20, 2023

Conversation

0b5vr
Copy link
Contributor

@0b5vr 0b5vr commented Mar 13, 2023

This PR addresses a part of #357

Why

to catch up with r150

What

Added stopListenToKeyEvents to OrbitControls.

Checklist

  • Checked the target branch (current goes master, next goes dev)
  • Added myself to contributors table
  • Ready to be merged

@0b5vr 0b5vr added the new release issues to do with the upcoming release of Three label Mar 13, 2023
@0b5vr 0b5vr self-assigned this Mar 13, 2023
@0b5vr 0b5vr mentioned this pull request Mar 13, 2023
Closed
8 tasks
@0b5vr 0b5vr requested a review from Methuselah96 March 20, 2023 03:22
@Methuselah96 Methuselah96 merged commit 3b73d22 into three-types:dev Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Methuselah96 Methuselah96 Methuselah96 approved these changes

Assignees

@0b5vr 0b5vr

Labels
new release issues to do with the upcoming release of Three
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0b5vr @Methuselah96