Add missing functions and properties in several classes #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… GLTFWriter, ObjectLoader, Material, Matrix3, Matrix4, WebGLMultipleRenderTargets
repalash
changed the title
Methuselah96
requested changes
Jun 4, 2023
Comment on lines
+90
to
+92
| static Utils: { | ||
| GLTFWriter: typeof GLTFWriter; | ||
| }; |
There was a problem hiding this comment.
I see Utils being set on GLTFExporter but I'm having trouble seeing where GLTFWriter is declared on it. Can you show where that happens?
There was a problem hiding this comment.
Oh, my bad, this was a change I was making a PR for three.js, forgot that its not there.
I will remove this change.
|
Hi @Methuselah96, No hurry, please take your time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in: OrbitControls, GLTFExporter, GLTFWriter, ObjectLoader, Material, Matrix3, Matrix4, WebGLMultipleRenderTargets
Why
Add missing properties and functions.
What
Extend OrbitControls from EventDispatcher like in three.js
Put GLTFWriter in GLTFExporter.Utils like in three.js
Add functions to GLTFWriter
Add
nameproperty in GLTFLoaderPluginAdd missing parse functions to GLTFLoader and fix return types of others.
Add onBeforeRender in Material
Add readonly props isMatrix3 and isMatrix4
Add samples to MultisampleRenderTargets
Checked the target branch (current goes
master, next goesdev)Added myself to contributors table
Ready to be merged