feat: Add types for VectorX iterators #475
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The threejs Vector classes can be iterated (and therefore spread in function calls). It would be nice to enable this functionality in TypeScript projects that use three.
What
This PR adds
[Symbol.iterator]()
method type declarations in theVector2
,Vector3
, andVector4
classes.Checklist
master
, next goesdev
)I am unable to add myself as a contributor to the repo using the instructions in the contribution guidelines - I get an
API rate limit exceeded
error :sThe doc-comments in this PR are copied from threejs documentation, from the commit that added iterators to the vector classes: mrdoob/three.js@fbdb745