Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add(usdzexporter): USDZExporterOptions for quick look compatibility #531

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .all-contributorsrc
Original file line number Diff line number Diff line change
Expand Up @@ -763,6 +763,15 @@
"contributions": [
"code"
]
},
{
"login": "ericbroberic",
"name": "Eric Benn",
"avatar_url": "https://avatars.githubusercontent.com/u/9359928?v=4",
"profile": "https://github.com/ericbroberic",
"contributions": [
"code"
]
}
],
"skipCi": true,
Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/d
<td align="center" valign="top" width="14.28%"><a href="https://github.com/magnostherobot"><img src="https://avatars.githubusercontent.com/u/24718981?v=4?s=100" width="100px;" alt="Tom Harley"/><br /><sub><b>Tom Harley</b></sub></a><br /><a href="https://github.com/three-types/three-ts-types/commits?author=Mik-pe" title="Code">💻</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/OndrejSpanel"><img src="https://avatars.githubusercontent.com/u/6927223?v=4?s=100" width="100px;" alt="Ondřej Španěl"/><br /><sub><b>Ondřej Španěl</b></sub></a><br /><a href="https://github.com/three-types/three-ts-types/issues?q=author%3AOndrejSpanel" title="Bug reports">🐛</a> <a href="https://github.com/three-types/three-ts-types/commits?author=OndrejSpanel" title="Code">💻</a> <a href="https://github.com/three-types/three-ts-types/commits?author=OndrejSpanel" title="Documentation">📖</a> <a href="#maintenance-OndrejSpanel" title="Maintenance">🚧</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/Yonet"><img src="https://avatars.githubusercontent.com/u/3523671?v=4?s=100" width="100px;" alt="Yönet"/><br /><sub><b>Yönet</b></sub></a><br /><a href="https://github.com/three-types/three-ts-types/commits?author=Yonet" title="Code">💻</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/ericbroberic"><img src="https://avatars.githubusercontent.com/u/9359928?v=4?s=100" width="100px;" alt="Eric Benn"/><br /><sub><b>Eric Benn</b></sub></a><br /><a href="https://github.com/three-types/three-ts-types/commits?author=ericbroberic" title="Code">💻</a></td>
</tr>
</tbody>
</table>
Expand Down
6 changes: 5 additions & 1 deletion types/three/examples/jsm/exporters/USDZExporter.d.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
import { Object3D } from '../../../src/Three';

export interface USDZExporterOptions {
quickLookCompatible?: boolean;
}

export class USDZExporter {
constructor();

parse(scene: Object3D): Promise<Uint8Array>;
parse(scene: Object3D, options?: USDZExporterOptions): Promise<Uint8Array>;
}