Better internal message switching #213
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add todos that need to be processed - Rename some structs - Handle callback errors (drop the connection from worker connections subset)
- Separate worker to its own strcture - Use cancellation token to track if either of reader or writer routines exited and make sure connection is removed from global sessions set
sameh-farouk
previously approved these changes
Apr 15, 2025
Also run cargo clippy to clean up all warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refactoring mainly tries to avoid worker getting blocked on slow clients and also avoid holding a global lock.
This does not solve everything. I will make sure to leave some TODOs to be picked up by the team.