Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore the set noder certificate without sudo #937

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

muhamadazmy
Copy link
Member

Description

this PR only restore a function that was remove before. It used to use sudo but we don't need sudo for it anymore but we still need the function

Copy link
Contributor

@renauter renauter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
Just to remind that only allowed certifiers can call set_node_certification():

if !AllowedNodeCertifiers::<T>::get()

Such allowed certifiers that can be added by council approval.
If this is the intention we are all good and we can merge.

@sameh-farouk
Copy link
Member

Such allowed certifiers that can be added by council approval.
If this is the intention we are all good and we can merge.

Yes, I believe this issue dealing with this

@sameh-farouk sameh-farouk merged commit 34002e6 into development Jan 16, 2024
3 checks passed
@sameh-farouk sameh-farouk deleted the development-certify-node branch January 16, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants