-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update msg to be more friendly in farms page #1703
Conversation
I think we should use |
yes, u're right. |
should be fixed in 29e54d8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we certain that a connection error is the only potential issue? What if there are problems with the Grid Proxy itself? Shouldn't the error message be more inclusive or at least address other possible scenarios beyond network issues?
|
@AlaaElattar example:
then check on the catch error |
…-sdk-ts into development_rephrase_error_farms
Done. I checked on error, there're 2 possibilities either connection error or error from gridproxy. |
found this issue while testing #1733 |
if (error instanceof ConnectionError) { | ||
createCustomToast("Failed to get farms. Please check your connection.", ToastType.danger); | ||
} else { | ||
createCustomToast("Failed to get farms.", ToastType.danger); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If i added same msg , what is the point then of checking on error type ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This issue should be fixed here #1735 @AlaaElattar @amiraabouhadid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amiraabouhadid Another error type not connection related might happen in the else, so I think it's better this way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked #1735 and it indeed fixes the issue in case no connection is needed.
|
Description
Changes
Error msg updated to
Failed to get farms. Please check your connection.
Related Issues
#1599
Checklist