update msg to be more friendly in farms page

[AlaaElattar]

Description

• Update error msg when there's problem getting user farms.

Changes

Error msg updated to Failed to get farms. Please check your connection.

Related Issues

#1599

Checklist

• Tests included
• Build pass
• Documentation
• Code format and docstrings
• Screenshots/Video attached (needed for UI changes)

[MohamedElmdary]

I think we should use normalizeError method and that string should be the fallback error
because now if any error happen user won't know @AlaaElattar

[AlaaElattar]

I think we should use normalizeError method and that string should be the fallback error because now if any error happen user won't know @AlaaElattar

yes, u're right.

[AlaaElattar]

I think we should use normalizeError method and that string should be the fallback error because now if any error happen user won't know @AlaaElattar

should be fixed in 29e54d8

[amiraabouhadid]

I got this error msg instead

[AlaaElattar]

I got this error msg instead

Fixed. will always show friendly error msg.

[zaelgohary]

Are we certain that a connection error is the only potential issue? What if there are problems with the Grid Proxy itself? Shouldn't the error message be more inclusive or at least address other possible scenarios beyond network issues?

[AlaaElattar]

Are we certain that a connection error is the only potential issue? What if there are problems with the Grid Proxy itself? Shouldn't the error message be more inclusive or at least address other possible scenarios beyond network issues?

• Here i tried if i can't reach proxy and i got same logs. Do u have an idea how to differentiate the connection error from any other error ?

[0oM4R]

Are we certain that a connection error is the only potential issue? What if there are problems with the Grid Proxy itself? Shouldn't the error message be more inclusive or at least address other possible scenarios beyond network issues?

• Here i tried if i can't reach proxy and i got same logs. Do u have an idea how to differentiate the connection error from any other error ?

@AlaaElattar
you can check on the error type, all errors should be an instance of a class on types package

example:

• import the type you want to check on here i will import validationError

then check on the catch error
if (error instanceof ValidationError)

[AlaaElattar]

Are we certain that a connection error is the only potential issue? What if there are problems with the Grid Proxy itself? Shouldn't the error message be more inclusive or at least address other possible scenarios beyond network issues?

• Here i tried if i can't reach proxy and i got same logs. Do u have an idea how to differentiate the connection error from any other error ?

@AlaaElattar you can check on the error type, all errors should be an instance of a class on types package

example:

• import the type you want to check on here i will import validationError

then check on the catch error if (error instanceof ValidationError)

Done. I checked on error, there're 2 possibilities either connection error or error from gridproxy.

[amiraabouhadid]

found this issue while testing #1733

[amiraabouhadid]

i got this . can you please add "Please check your connection. " here too? you can also just save the toast in a variable and reuse it instead of repeating code

[AlaaElattar]

If i added same msg , what is the point then of checking on error type ?

[MohamedElmdary]

This issue should be fixed here #1735 @AlaaElattar @amiraabouhadid

[zaelgohary]

@amiraabouhadid Another error type not connection related might happen in the else, so I think it's better this way.

[zaelgohary]

I checked #1735 and it indeed fixes the issue in case no connection is needed.

Need changes after #1735 is merged

[AlaaElattar]

• I removed the connection check on error as when this pr fix grid client disconnecting while connecting #1735 merged, this will happen with any case of internet connection.