Adding selection field for keypair type #1709
Conversation
maayarosama
requested review from
AhmedHanafy725,
zaelgohary,
MohamedElmdary,
Mahmoud-Emad,
amiraabouhadid,
Omarabdul3ziz,
AlaaElattar and
0oM4R
as code owners
| @@ -638,6 +659,7 @@ async function createNewAccount() { | |||
| creatingAccount.value = true; | |||
| try { | |||
| const account = await createAccount(); | |||
| console.log("account", account); | |||
There was a problem hiding this comment.
please remove the debug logs
| @@ -710,6 +732,7 @@ profileManagerController.set({ loadBalance: __loadBalance }); | |||
|
|
|||
| function login() { | |||
| const credentials: Credentials = getCredentials(); | |||
| console.log(credentials); | |||
Screencast.from.12-19-2023.03.00.31.PM.webm |
|
not sure if we should move the new warning message to the top or keep it. But if we keep it, I think it should have some spacing after @ehab-hassan
|
| @@ -252,6 +267,9 @@ | |||
| <v-alert type="error" variant="tonal" class="mt-2 mb-4" v-if="loginError"> | |||
| {{ loginError }} | |||
| </v-alert> | |||
| <v-alert variant="tonal" type="warning" v-if="activeTab === 1"> | |||
There was a problem hiding this comment.
It feels more like an info not a warning , what do u think ?
|
Also as long as the user can't create account with ed25519 (just import pre existing account), I think w should say that somewhere. |
yes please let's keep it down and make sure to have the same margin's first warning message had. |
| } | ||
| }, | ||
| { deep: false }, | ||
| ); |
There was a problem hiding this comment.
can we please update the message on line 567 to "Couldn't get the user twin for the provided mnemonic and keytype".
Description
Adding selection for key pair type in profile manager
Changes
Related Issues
#1113
Checklist