Add exit code to in case of error in test script

[A-Harby]

Description

After the update script issue, the tests have been failing but passing in the test result because of the try and catch that have been added to the code. Removed all the try and catch from the scripts and added a checker after the delete all.

Update the yggdrasil version to the latest v0.5.4.

Changes

Only the scripts that are included in the grid nightly workflow.

Related Issues

#1673
#950

#1756

[zaelgohary]

Maybe we can throw the error instead of logging it and exiting the process? Also, not all scripts are updated.

[xmonader]

We need to make sure clean up function is always executed

[AhmedHanafy725]

Maybe we can throw the error instead of logging it and exiting the process? Also, not all scripts are updated.

let's remove the try-catch block in case we need to make it crash on failure. There is no need for it

[A-Harby]

• Removed try-catch from the test scripts, then all of them.
• Update the workflow to check that all the contracts are deleted after cleaning up, and if not, the workflow will fail.
• Change the time to 4 AM to run before mass deployment by 2 hours.
• Tested both successful run and deletion failure.

[A-Harby]

@mohamedamer453 I fixed both comments and tested both workflows. https://github.com/threefoldtech/tfgrid-sdk-ts/actions/runs/7395367664/job/20118396746 and https://github.com/threefoldtech/tfgrid-sdk-ts/actions/runs/7395403959/job/20118505842.

Could you re-review?

[mohamedamer453]

In this run you can see that the contracts were deleted successfully, however the run failed in the Check if contracts are empty step, i think it might be giving a false positive, the issue might be that it needs a bit of time before listing all contracts to register that the contracts were deleted, so if it's possible to increase the timeout before doing this step to ensure that it's not giving a false positive.

[A-Harby]

In this run you can see that the contracts were deleted successfully, however the run failed in the Check if contracts are empty step, i think it might be giving a false positive, the issue might be that it needs a bit of time before listing all contracts to register that the contracts were deleted, so if it's possible to increase the timeout before doing this step to ensure that it's not giving a false positive.

This should be fixed and I test it here.

[mohamedamer453]

After the latest run the workflow seems to be working fine. great work!