Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add scripts and tests #2163

Closed
wants to merge 1 commit into from
Closed

add scripts and tests #2163

wants to merge 1 commit into from

Conversation

khaledyoussef24
Copy link
Contributor

@khaledyoussef24 khaledyoussef24 commented Feb 14, 2024 •
edited
Loading

Description

add scripts and tests
#1841

Changes

List of changes this PR includes
tests and scripts for all of the solutions

Related Issues

List of related issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

AlaaElattar
AlaaElattar reviewed Feb 15, 2024
View reviewed changes
Copy link
Contributor

@AlaaElattar AlaaElattar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • you should add mycelium flag, it's mandatory just as planetary.
  • all scripts won't run without it.
    image

@khaledyoussef24
Copy link
Contributor Author

wip :
adding the flag to all of the scripts and tests

@xmonader
Copy link
Contributor

@khaledyoussef24 please make sure next time to use a proper branch name development_new_scripts means nothing

@khaledyoussef24
Copy link
Contributor Author

okay, will make sure next time that it would be more descriptive.
can i make a sub-folder inside the scripts for the applications?

@AhmedHanafy725 AhmedHanafy725 deleted the development_new_scripts branch February 27, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlaaElattar AlaaElattar AlaaElattar left review comments

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khaledyoussef24 @xmonader @AlaaElattar