Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development selenium add stats page tests 1 #3313

Open
wants to merge 16 commits into
base: development
Choose a base branch
from

Conversation

Marinaa-Emad
Copy link
Collaborator

Description

The data rendered in the statistics page should be match the data available in the gridproxy, and check the navigation of Node Monitoring button and Grid Status button.

Changes

Add statistics page and statistics page tests and there are some changes in grid_proxy page and utils page.

Documentation PR

For UI changes, Please provide the Documetation PR on info_grid

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@amiraabouhadid
Copy link
Contributor

please resolve conflicts

@A-Harby A-Harby marked this pull request as draft August 19, 2024 11:02
@A-Harby A-Harby marked this pull request as ready for review August 28, 2024 17:32
@0oM4R
Copy link
Contributor

0oM4R commented Sep 23, 2024

I can't verify the results, #3421,
tests it passing but need to verify the values

@A-Harby
Copy link
Contributor

A-Harby commented Oct 13, 2024

I can't verify the results, #3421, tests it passing but need to verify the values

The new tests here are only for the stats page on the dashboard, and the values are checked directly with the proxy stats endpoint (up and standby).

The issue is concerning about the statistics summary endpoint, which is not used here.

@A-Harby
Copy link
Contributor

A-Harby commented Oct 17, 2024

All done with added comments and docstring.

And 2 tests are passing.
image

@A-Harby A-Harby requested a review from 0oM4R October 17, 2024 11:46
@A-Harby A-Harby requested a review from 0oM4R October 24, 2024 15:05
@0oM4R
Copy link
Contributor

0oM4R commented Oct 30, 2024

LGTM, please provide new test result

@A-Harby
Copy link
Contributor

A-Harby commented Oct 30, 2024

I tested it again and all passed.

Small change was in the condition of conversion of GB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants