Development selenium add stats page tests 1 #3313
Open
+211
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marinaa-Emad
requested review from
AhmedHanafy725,
zaelgohary,
maayarosama,
MohamedElmdary,
Mahmoud-Emad,
amiraabouhadid,
AlaaElattar,
0oM4R,
mohamedamer453 and
samaradel
as code owners
|
please resolve conflicts |
A-Harby
reviewed
Aug 20, 2024
A-Harby
reviewed
Aug 21, 2024
khaledyoussef24
approved these changes
Sep 3, 2024
|
I can't verify the results, #3421, |
The new tests here are only for the stats page on the dashboard, and the values are checked directly with the proxy stats endpoint (up and standby). The issue is concerning about the statistics summary endpoint, which is not used here. |
0oM4R
requested changes
Oct 15, 2024
packages/playground/tests/frontend_selenium/tests/TFGrid/test_statistics.py
Outdated
Show resolved
Hide resolved
packages/playground/tests/frontend_selenium/tests/TFGrid/test_statistics.py
Show resolved
Hide resolved
|
All done with added comments and docstring. And 2 tests are passing. |
0oM4R
reviewed
Oct 24, 2024
|
LGTM, please provide new test result |
|
I tested it again and all passed. Small change was in the condition of conversion of GB. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The data rendered in the statistics page should be match the data available in the gridproxy, and check the navigation of Node Monitoring button and Grid Status button.
Changes
Add statistics page and statistics page tests and there are some changes in grid_proxy page and utils page.
Documentation PR
For UI changes, Please provide the Documetation PR on info_grid
Checklist