-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance networks Component #3344
base: development
Are you sure you want to change the base?
Conversation
feat: Refactor Networks component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job ya MR-Rabeeee3
…rks_output Enhance networks output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Teslam edak ya Rabe3
const ipv6 = ref(false); | ||
const mycelium = ref(true); | ||
const planetary = ref(true); | ||
const { ipv4, ipv6, mycelium, planetary } = useNetworks({ planetary: true }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
require-domain should be added to the Networks tag in template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- require-domain isn't a network so it shouldn't be used in
useNetworks
require-domain
won't change for specific solution (solution will need domain or not)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed but it is only useful for the tooltip it shows here:
tfgrid-sdk-ts/packages/playground/src/components/networks.vue
Lines 143 to 147 in 30b685a
const wireguardTooltip = computed(() => | |
props.requireDomain | |
? "Enabling WireGuard Access allows you to establish private, secure, and encrypted instance connections. Please note that this field will be read-only unless you use a custom domain with IPV4." | |
: "Enabling WireGuard Access allows you to establish private, secure, and encrypted instance connections.", | |
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's also used as readonly for wireguard
Screencast.from.2024-09-02.14-26-43.webmthe only case we should have the wg not readonly is: when having ipv4 with customDomain enabled |
); | ||
expose({ | ||
error, | ||
const error = computed(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is because it's not required but I checked early versions and it wasn't require too should I turn it into required?
tooltip-text="An Internet Protocol version 4 address that is globally unique and accessible over the internet." | ||
label="Public IPv4" | ||
:value="$props.ipv4" | ||
:emit-function="$attrs['onUpdate:ipv4']" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on caprover we need the ipv4 to be read only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be fixed
also I was able to deploy an algorand instance while disable all network options, |
add wireguard,
set wg value to false when readonlywireguard is false
Description
Enhance networks Component
Changes
Related Issues
Documentation PR
For UI changes, Please provide the Documetation PR on info_grid
Checklist