Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow using username and email in SMTP configuration #3398

Merged
merged 18 commits into from
Oct 21, 2024
Merged

Allow using username and email in SMTP configuration #3398

merged 18 commits into from
Oct 21, 2024

Commits on Sep 10, 2024

  1. Remove isDiscourse check and apply adding email or username for all a… 

    …pps with smtp
    @samaradel
    samaradel committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    cd7e4e4 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Update packages/playground/src/components/smtp_server.vue 

    Co-authored-by: Zainab Elgohary <[email protected]>
    @samaradel @zaelgohary
    samaradel and zaelgohary authored Sep 11, 2024
    Configuration menu
    Copy the full SHA
    6f50303 View commit details
    Browse the repository at this point in the history

  2. Update packages/playground/src/weblets/tf_discourse.vue 

    Co-authored-by: Zainab Elgohary <[email protected]>
    @samaradel @zaelgohary
    samaradel and zaelgohary authored Sep 11, 2024
    Configuration menu
    Copy the full SHA
    f994a54 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Validate SMTP username/email

    @samaradel
    samaradel committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    b7a7836 View commit details
    Browse the repository at this point in the history

  2. Fix build

    @samaradel
    samaradel committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    81af97c View commit details
    Browse the repository at this point in the history

  3. Apply code scanning fix for overly permissive regular expression range 

    Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
    @samaradel @github-advanced-security
    samaradel and github-advanced-security[bot] authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    bc4c149 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Update packages/playground/src/utils/validators.ts 

    Co-authored-by: Omar Kassem <[email protected]>
    @samaradel @0oM4R
    samaradel and 0oM4R authored Sep 23, 2024
    Configuration menu
    Copy the full SHA
    4c1c955 View commit details
    Browse the repository at this point in the history

  2. rn validate smtp function

    @samaradel
    samaradel committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    f2e0fc8 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Rename validate function parameter

    @samaradel
    samaradel committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    f3bbf8d View commit details
    Browse the repository at this point in the history

  2. Add doc string for validate smtp function

    @samaradel
    samaradel committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    a05eb55 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2024

  1. - Set validation to limit username 

    - Add space checker in validator function
- Add unit test for smtp validation function
    @samaradel
    samaradel committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    0674977 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. - Add min length and max length for the username and Email 

    - Accept usernames that contain dashs and underscores and it must start with an alphabetical character and validate them
    @samaradel
    samaradel committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    788077b View commit details
    Browse the repository at this point in the history

  2. Add doc string for IsAlphaExpectDashAndUnderscore validator

    @samaradel
    samaradel committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    0d6a1b3 View commit details
    Browse the repository at this point in the history

  3. Add unit test for IsAlphaExpectDashAndUnderscore function

    @samaradel
    samaradel committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    9fb6875 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Update SMTP input validation msg

    @samaradel
    samaradel committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    4ad30a6 View commit details
    Browse the repository at this point in the history

  2. Update SMTP input validation msg

    @samaradel
    samaradel committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    51465dc View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2024

  1. Remove number validator of first char and add test case for it

    @samaradel
    samaradel committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    b9ff25e View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Modify the valitator function to accept numbers too

    @samaradel
    samaradel committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    17e8dba View commit details
    Browse the repository at this point in the history