-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding workload unit tests #3403
base: development
Are you sure you want to change the base?
Conversation
case WorkloadTypes.zmachine: | ||
instance = new Zmachine(); | ||
computeCapacity.cpu = 1; | ||
computeCapacity.memory = 256 * 1024 ** 2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be a good idea to declare 1024 as a constant as it is used more than once
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be a good idea to declare 1024 as a constant as it is used more than once
I think this's not needed as I only used twice and the 1024 indicates the number of bytes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why aren't there test cases for the zmount and qsfs workload type?
Please elaborate |
why do you only have tests for workload type zmachine when there are other types we can test as well? I think we should write more tests that test workload types other than zmachine for a more extensive test coverage. |
Description
Added six test case for workload
Changes
Test cases are:
Related Issues
Tested Scenarios
Checklist