-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: suppot TFGrid-KYC #3531
base: development
Are you sure you want to change the base?
Feat: suppot TFGrid-KYC #3531
Conversation
…into development_kyc_gridClient
…-ts into development_kyc_gridClient
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Screencast from 23-10-24 15:34:39.webm
it keeps loading
did you build the clients ? |
@0oM4R yes I did |
Update: It was from |
905b466
to
15852f6
Compare
- cleanup code
|
||
case status === HttpStatusCode.PaymentRequired: | ||
return new InsufficientBalanceError(errorMessage); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default case was removed by mistake, added now
Unverified, | ||
InvalidResponse, | ||
RateLimit, | ||
badRequest, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the inconsistency? Change to BadRequest, Unauthorized!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated; thank you!
Description
Add KYC client to grid client, dashboard, and types packages.
changes:
grid client:
types: add related error classes
dashboard:
tested scenarios:
related issues:
info issue: threefoldtech/info_grid#666
screenshots: