Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: suppot TFGrid-KYC #3531

Open
wants to merge 49 commits into
base: development
Choose a base branch
from
Open

Feat: suppot TFGrid-KYC #3531

wants to merge 49 commits into from

Conversation

0oM4R
Copy link
Contributor

@0oM4R 0oM4R commented Oct 16, 2024 •
edited
Loading

Description

Add KYC client to grid client, dashboard, and types packages.

changes:

  • grid client:

    • add kyc client
    • add kyc client to grid client
    • check if kyc verified on create name and handle methods in twinddeployment

  • types: add related error classes

  • dashboard:

    • add kyc verifier that uses iframe to connect to idenfy
    • add kyc store, init on profile, clear if no profile
    • prevent deployment if kyc is not verified, in view layout

tested scenarios:

  • try to deploy without kyc verification all deployments should be blocked
  • check twin page to see the kyc status
  • use kyc client and check its methods
  • check error handling in dashboard, toast etc, you can manipulate the headers in kyc client
  • check if you can deploy without kyc in gridclient
  • try to enter the verification process then cancel
  • try to have rejected kyc verification
  • try to verify the kyc with valid data using the dashboard
  • try to scan the qr code and continue verification process on mobile
  • make sure that the kyc status got cleaned after logout/refresh

related issues:

info issue: threefoldtech/info_grid#666

screenshots:
Screenshot from 2024-10-23 12-21-41
Screenshot from 2024-10-23 12-21-33
image
Screenshot from 2024-10-23 12-27-40
Screenshot from 2024-10-23 12-27-19
image
image

AhmedHanafy725
AhmedHanafy725 requested changes Oct 16, 2024
View reviewed changes
packages/grid_client/src/clients/kyc/client.ts Outdated Show resolved Hide resolved
packages/grid_client/src/clients/kyc/client.ts Outdated Show resolved Hide resolved
packages/grid_client/src/clients/kyc/client.ts Outdated Show resolved Hide resolved
packages/grid_client/src/clients/kyc/client.ts Outdated Show resolved Hide resolved
packages/grid_client/src/clients/kyc/client.ts Show resolved Hide resolved
@0oM4R
chore: export KYC client
c6f9e07
@0oM4R
Chore:
154c17f 
- add stringToHex and bytesFromHex to utils
- remove private utils from KYC client and use them from utils
@0oM4R
chore : use urlJoin
ef66fde
@0oM4R
refactor: retrive address from mnemoinic
3d14655
@0oM4R 0oM4R mentioned this pull request Oct 16, 2024
Open
@0oM4R 0oM4R marked this pull request as draft October 21, 2024 14:30
samaradel
samaradel reviewed Oct 23, 2024
View reviewed changes
Copy link
Contributor

@samaradel samaradel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screencast from 23-10-24 15:34:39.webm
it keeps loading

@0oM4R
Copy link
Contributor Author

0oM4R commented Oct 23, 2024

Screencast from 23-10-24 15:34:39.webm it keeps loading

did you build the clients ?

@samaradel
Copy link
Contributor

@0oM4R yes I did

@samaradel
Copy link
Contributor

Screencast from 23-10-24 15:34:39.webm it keeps loading

Update: It was from react extension was enabled and it works when it disabled.

@0oM4R
Fix:
5d7fd30 
- clear event listener before close kycdiloge
- get the info to kyc from config
@0oM4R
chore: enhance error messages
5a28b4f
@0oM4R
Refactor:
be22124 
enhance errors
@0oM4R
Refactor:
395f606 
enhance errors
@0oM4R
fix: headers, enahnce error msg
3096bfa
@0oM4R 0oM4R requested a review from samaradel October 29, 2024 13:54
@0oM4R 0oM4R self-assigned this Oct 30, 2024
@0oM4R 0oM4R marked this pull request as draft October 30, 2024 09:25
@0oM4R 0oM4R marked this pull request as ready for review October 30, 2024 10:04
xmonader
xmonader reviewed Oct 30, 2024
View reviewed changes
packages/grid_client/src/clients/kyc/client.ts

case status === HttpStatusCode.PaymentRequired:
return new InsufficientBalanceError(errorMessage);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And else?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default case was removed by mistake, added now

xmonader
xmonader reviewed Oct 30, 2024
View reviewed changes
packages/types/src/errors/grid_client/kyc.ts Outdated
Unverified,
InvalidResponse,
RateLimit,
badRequest,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the inconsistency? Change to BadRequest, Unauthorized!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated; thank you!

@0oM4R
refactor:
38539a3 
- add default case to throwkycError method
- make errors enum values consist with each other
- rephrase error message in twinDeploymentHandler
@0oM4R
feat: add isHealty to kyc client
5ad3c2f
@0oM4R 0oM4R requested a review from xmonader October 30, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@samaradel samaradel Awaiting requested review from samaradel samaradel is a code owner

@xmonader xmonader Awaiting requested review from xmonader

Requested changes must be addressed to merge this pull request.

Assignees

@0oM4R 0oM4R

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@0oM4R @samaradel @xmonader @AhmedHanafy725 @amiraabouhadid