-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix theme switch #3534
Fix theme switch #3534
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on refresh the theme returned to the light mode
Screencast.from.2024-10-17.15-16-34.webm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#3534 (review)
still, it keep track the system mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When my system is in light mode, it doesn't work
Screencast from 2024-10-20 12-23-55.webm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the system theme got changed it will reflect immediately, but i think this is not related.
Description
Fix the theme switch in the app bar and setting page
Changes
Screencast.from.17-10-24.13.27.15.webm
Related Issues
Tested Scenarios
Checklist