Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix theme switch #3534

Merged
merged 4 commits into from
Oct 22, 2024
Merged

Fix theme switch #3534

merged 4 commits into from
Oct 22, 2024

Conversation

samaradel
Copy link
Contributor

@samaradel samaradel commented Oct 17, 2024 •
edited
Loading

Description

Fix the theme switch in the app bar and setting page

Changes

Screencast.from.17-10-24.13.27.15.webm

Related Issues

Tested Scenarios

  • Switch between light and dark mode.
  • Go to setting page and check the current mode in the input.
  • Select another mode and see if it reflected.

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

0oM4R
0oM4R requested changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@0oM4R 0oM4R left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on refresh the theme returned to the light mode

Screencast.from.2024-10-17.15-16-34.webm

@samaradel samaradel marked this pull request as draft October 17, 2024 13:26
@samaradel samaradel marked this pull request as ready for review October 17, 2024 14:26
@samaradel samaradel requested a review from 0oM4R October 17, 2024 14:26
maayarosama
maayarosama previously approved these changes Oct 20, 2024
View reviewed changes
0oM4R
0oM4R requested changes Oct 20, 2024
View reviewed changes
Copy link
Contributor

@0oM4R 0oM4R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3534 (review)
still, it keep track the system mode

maayarosama
maayarosama requested changes Oct 20, 2024
View reviewed changes
Copy link
Contributor

@maayarosama maayarosama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When my system is in light mode, it doesn't work
Screencast from 2024-10-20 12-23-55.webm

@samaradel samaradel marked this pull request as draft October 20, 2024 13:08
@samaradel samaradel marked this pull request as ready for review October 21, 2024 13:24
0oM4R
0oM4R approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@0oM4R 0oM4R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the system theme got changed it will reflect immediately, but i think this is not related.

@samaradel samaradel merged commit 1b54bd9 into development Oct 22, 2024
10 checks passed
@samaradel samaradel deleted the development_theme branch October 22, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amiraabouhadid amiraabouhadid amiraabouhadid approved these changes

@0oM4R 0oM4R 0oM4R approved these changes

@maayarosama maayarosama maayarosama approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samaradel @amiraabouhadid @0oM4R @maayarosama