update max name length from 50 to 35

[amiraabouhadid]

Changes

• changed max name length in deployment model in client
• changed max name length in all deployment dashboard validation

Related Issues

#2364

Tested Scenarios

• entered a name longer than 35 chars in dashboard deployments

[0oM4R]

is there a reason for gitea to be only 15 char ?

[amiraabouhadid]

is there a reason for gitea to be only 15 char ?

good question, for node pilot too @zaelgohary ?

[zaelgohary]

is there a reason for gitea to be only 15 char ?

good question, for node pilot too @zaelgohary ?

I'm not sure if node pilot has another restriction rule on its own but you may try to deploy and check if it works.

[amiraabouhadid]

@0oM4R changing gitea and node pilot name max length to 35 and deploying throws this error

so won't be changing gitea and node pilot max length from 15 to 35

[0oM4R]

i think we need to handle gatewaynameModal length, i see it got changed here

it is happening with matermost

[amiraabouhadid]

@0oM4R good catch, got validation error for more than 36 chars indeed

it has been set to 35 char max now

[0oM4R]

i think we have to update gatewaynameModel to accept the namelength + length of the domain @AhmedHanafy725 can you please provide numbers here ?

this was already exists but I don't know why it got removed
after manage that please update gitea and node pilot domain names