Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update max name length from 50 to 35 #3549

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

amiraabouhadid
Copy link
Contributor

@amiraabouhadid amiraabouhadid commented Oct 23, 2024

Changes

  • changed max name length in deployment model in client
  • changed max name length in all deployment dashboard validation

Related Issues

#2364

Tested Scenarios

  • entered a name longer than 35 chars in dashboard deployments

image

Copy link
Contributor

@0oM4R 0oM4R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

is there a reason for gitea to be only 15 char ?

@amiraabouhadid
Copy link
Contributor Author

image

is there a reason for gitea to be only 15 char ?

good question, for node pilot too @zaelgohary ?

@zaelgohary
Copy link
Contributor

is there a reason for gitea to be only 15 char ?

good question, for node pilot too @zaelgohary ?

I'm not sure if node pilot has another restriction rule on its own but you may try to deploy and check if it works.

@amiraabouhadid
Copy link
Contributor Author

amiraabouhadid commented Oct 28, 2024

@0oM4R changing gitea and node pilot name max length to 35 and deploying throws this error

image

image

so won't be changing gitea and node pilot max length from 15 to 35

Copy link
Contributor

@0oM4R 0oM4R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we need to handle gatewaynameModal length, i see it got changed here

it is happening with matermost
Screenshot from 2024-10-29 13-32-50

@amiraabouhadid
Copy link
Contributor Author

@0oM4R good catch, got validation error for more than 36 chars indeed
image
it has been set to 35 char max now

Copy link
Contributor

@0oM4R 0oM4R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we have to update gatewaynameModel to accept the namelength + length of the domain @AhmedHanafy725 can you please provide numbers here ?

this was already exists but I don't know why it got removed
after manage that please update gitea and node pilot domain names

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants